evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused device class from Renault select (#83330)

Browse source 
* Remove unused device class from Renault select

* Fix tests

* More
This commit is contained in:
Franck Nijhof 2022-12-06 11:27:07 +01:00 • committed by GitHub
parent c25ba19ffd
commit 6c74809400
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
homeassistant/components/renault/const.py
View file

@ -15,7 +15,3 @@ PLATFORMS = [
Platform.SELECT,
Platform.SENSOR,
]
DEVICE_CLASS_PLUG_STATE = "renault__plug_state"
DEVICE_CLASS_CHARGE_STATE = "renault__charge_state"
DEVICE_CLASS_CHARGE_MODE = "renault__charge_mode"

3
homeassistant/components/renault/select.py
View file

@ -13,7 +13,7 @@ from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.typing import StateType
from .const import DEVICE_CLASS_CHARGE_MODE, DOMAIN
from .const import DOMAIN
from .renault_entities import RenaultDataEntity, RenaultDataEntityDescription
from .renault_hub import RenaultHub
@ -90,7 +90,6 @@ SENSOR_TYPES: tuple[RenaultSelectEntityDescription, ...] = (
key="charge_mode",
coordinator="charge_mode",
data_key="chargeMode",
device_class=DEVICE_CLASS_CHARGE_MODE,
icon_lambda=_get_charge_mode_icon,
name="Charge mode",
options=["always", "always_charging", "schedule_mode"],

4
homeassistant/components/renault/sensor.py
View file

@ -36,7 +36,7 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.typing import StateType
from homeassistant.util.dt import as_utc, parse_datetime
from .const import DEVICE_CLASS_CHARGE_STATE, DEVICE_CLASS_PLUG_STATE, DOMAIN
from .const import DOMAIN
from .renault_coordinator import T
from .renault_entities import RenaultDataEntity, RenaultDataEntityDescription
from .renault_hub import RenaultHub
@ -171,7 +171,6 @@ SENSOR_TYPES: tuple[RenaultSensorEntityDescription[Any], ...] = (
key="charge_state",
coordinator="battery",
data_key="chargingStatus",
device_class=DEVICE_CLASS_CHARGE_STATE,
entity_class=RenaultSensor[KamereonVehicleBatteryStatusData],
icon_lambda=_get_charge_state_icon,
name="Charge state",
@ -219,7 +218,6 @@ SENSOR_TYPES: tuple[RenaultSensorEntityDescription[Any], ...] = (
key="plug_state",
coordinator="battery",
data_key="plugStatus",
device_class=DEVICE_CLASS_PLUG_STATE,
entity_class=RenaultSensor[KamereonVehicleBatteryStatusData],
icon_lambda=_get_plug_state_icon,
name="Plug state",

12
tests/components/renault/const.py
View file

@ -3,9 +3,6 @@ from homeassistant.components.binary_sensor import BinarySensorDeviceClass
from homeassistant.components.renault.const import (
CONF_KAMEREON_ACCOUNT_ID,
CONF_LOCALE,
DEVICE_CLASS_CHARGE_MODE,
DEVICE_CLASS_CHARGE_STATE,
DEVICE_CLASS_PLUG_STATE,
DOMAIN,
)
from homeassistant.components.select import ATTR_OPTIONS
@ -121,7 +118,6 @@ MOCK_VEHICLES = {
Platform.DEVICE_TRACKER: [],
Platform.SELECT: [
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_MODE,
ATTR_ENTITY_ID: "select.reg_number_charge_mode",
ATTR_ICON: "mdi:calendar-remove",
ATTR_OPTIONS: ["always", "always_charging", "schedule_mode"],
@ -171,7 +167,6 @@ MOCK_VEHICLES = {
ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
},
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_STATE,
ATTR_ENTITY_ID: "sensor.reg_number_charge_state",
ATTR_ICON: "mdi:flash",
ATTR_STATE: "charge_in_progress",
@ -224,7 +219,6 @@ MOCK_VEHICLES = {
ATTR_UNIQUE_ID: "vf1aaaaa555777999_hvac_last_activity",
},
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_PLUG_STATE,
ATTR_ENTITY_ID: "sensor.reg_number_plug_state",
ATTR_ICON: "mdi:power-plug",
ATTR_STATE: "plugged",
@ -340,7 +334,6 @@ MOCK_VEHICLES = {
],
Platform.SELECT: [
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_MODE,
ATTR_ENTITY_ID: "select.reg_number_charge_mode",
ATTR_ICON: "mdi:calendar-clock",
ATTR_OPTIONS: ["always", "always_charging", "schedule_mode"],
@ -390,7 +383,6 @@ MOCK_VEHICLES = {
ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
},
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_STATE,
ATTR_ENTITY_ID: "sensor.reg_number_charge_state",
ATTR_ICON: "mdi:flash-off",
ATTR_STATE: "charge_error",
@ -443,7 +435,6 @@ MOCK_VEHICLES = {
ATTR_UNIQUE_ID: "vf1aaaaa555777999_hvac_last_activity",
},
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_PLUG_STATE,
ATTR_ENTITY_ID: "sensor.reg_number_plug_state",
ATTR_ICON: "mdi:power-plug-off",
ATTR_STATE: "unplugged",
@ -559,7 +550,6 @@ MOCK_VEHICLES = {
],
Platform.SELECT: [
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_MODE,
ATTR_ENTITY_ID: "select.reg_number_charge_mode",
ATTR_ICON: "mdi:calendar-remove",
ATTR_OPTIONS: ["always", "always_charging", "schedule_mode"],
@ -609,7 +599,6 @@ MOCK_VEHICLES = {
ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS,
},
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_STATE,
ATTR_ENTITY_ID: "sensor.reg_number_charge_state",
ATTR_ICON: "mdi:flash",
ATTR_STATE: "charge_in_progress",
@ -659,7 +648,6 @@ MOCK_VEHICLES = {
ATTR_UNIT_OF_MEASUREMENT: LENGTH_KILOMETERS,
},
{
ATTR_DEVICE_CLASS: DEVICE_CLASS_PLUG_STATE,
ATTR_ENTITY_ID: "sensor.reg_number_plug_state",
ATTR_ICON: "mdi:power-plug",
ATTR_STATE: "plugged",