From 6c74809400f40bd3890ffb43f282dc169370f975 Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Tue, 6 Dec 2022 11:27:07 +0100 Subject: [PATCH] Remove unused device class from Renault select (#83330) * Remove unused device class from Renault select * Fix tests * More --- homeassistant/components/renault/const.py | 4 ---- homeassistant/components/renault/select.py | 3 +-- homeassistant/components/renault/sensor.py | 4 +--- tests/components/renault/const.py | 12 ------------ 4 files changed, 2 insertions(+), 21 deletions(-) diff --git a/homeassistant/components/renault/const.py b/homeassistant/components/renault/const.py index b29f4ad0701..8e68eac01eb 100644 --- a/homeassistant/components/renault/const.py +++ b/homeassistant/components/renault/const.py @@ -15,7 +15,3 @@ PLATFORMS = [ Platform.SELECT, Platform.SENSOR, ] - -DEVICE_CLASS_PLUG_STATE = "renault__plug_state" -DEVICE_CLASS_CHARGE_STATE = "renault__charge_state" -DEVICE_CLASS_CHARGE_MODE = "renault__charge_mode" diff --git a/homeassistant/components/renault/select.py b/homeassistant/components/renault/select.py index 2a1e207695c..bd383a07187 100644 --- a/homeassistant/components/renault/select.py +++ b/homeassistant/components/renault/select.py @@ -13,7 +13,7 @@ from homeassistant.core import HomeAssistant from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.typing import StateType -from .const import DEVICE_CLASS_CHARGE_MODE, DOMAIN +from .const import DOMAIN from .renault_entities import RenaultDataEntity, RenaultDataEntityDescription from .renault_hub import RenaultHub @@ -90,7 +90,6 @@ SENSOR_TYPES: tuple[RenaultSelectEntityDescription, ...] = ( key="charge_mode", coordinator="charge_mode", data_key="chargeMode", - device_class=DEVICE_CLASS_CHARGE_MODE, icon_lambda=_get_charge_mode_icon, name="Charge mode", options=["always", "always_charging", "schedule_mode"], diff --git a/homeassistant/components/renault/sensor.py b/homeassistant/components/renault/sensor.py index 436b9209e89..4d174f1e7d5 100644 --- a/homeassistant/components/renault/sensor.py +++ b/homeassistant/components/renault/sensor.py @@ -36,7 +36,7 @@ from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.typing import StateType from homeassistant.util.dt import as_utc, parse_datetime -from .const import DEVICE_CLASS_CHARGE_STATE, DEVICE_CLASS_PLUG_STATE, DOMAIN +from .const import DOMAIN from .renault_coordinator import T from .renault_entities import RenaultDataEntity, RenaultDataEntityDescription from .renault_hub import RenaultHub @@ -171,7 +171,6 @@ SENSOR_TYPES: tuple[RenaultSensorEntityDescription[Any], ...] = ( key="charge_state", coordinator="battery", data_key="chargingStatus", - device_class=DEVICE_CLASS_CHARGE_STATE, entity_class=RenaultSensor[KamereonVehicleBatteryStatusData], icon_lambda=_get_charge_state_icon, name="Charge state", @@ -219,7 +218,6 @@ SENSOR_TYPES: tuple[RenaultSensorEntityDescription[Any], ...] = ( key="plug_state", coordinator="battery", data_key="plugStatus", - device_class=DEVICE_CLASS_PLUG_STATE, entity_class=RenaultSensor[KamereonVehicleBatteryStatusData], icon_lambda=_get_plug_state_icon, name="Plug state", diff --git a/tests/components/renault/const.py b/tests/components/renault/const.py index 97499d19bea..b288045c3b4 100644 --- a/tests/components/renault/const.py +++ b/tests/components/renault/const.py @@ -3,9 +3,6 @@ from homeassistant.components.binary_sensor import BinarySensorDeviceClass from homeassistant.components.renault.const import ( CONF_KAMEREON_ACCOUNT_ID, CONF_LOCALE, - DEVICE_CLASS_CHARGE_MODE, - DEVICE_CLASS_CHARGE_STATE, - DEVICE_CLASS_PLUG_STATE, DOMAIN, ) from homeassistant.components.select import ATTR_OPTIONS @@ -121,7 +118,6 @@ MOCK_VEHICLES = { Platform.DEVICE_TRACKER: [], Platform.SELECT: [ { - ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_MODE, ATTR_ENTITY_ID: "select.reg_number_charge_mode", ATTR_ICON: "mdi:calendar-remove", ATTR_OPTIONS: ["always", "always_charging", "schedule_mode"], @@ -171,7 +167,6 @@ MOCK_VEHICLES = { ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS, }, { - ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_STATE, ATTR_ENTITY_ID: "sensor.reg_number_charge_state", ATTR_ICON: "mdi:flash", ATTR_STATE: "charge_in_progress", @@ -224,7 +219,6 @@ MOCK_VEHICLES = { ATTR_UNIQUE_ID: "vf1aaaaa555777999_hvac_last_activity", }, { - ATTR_DEVICE_CLASS: DEVICE_CLASS_PLUG_STATE, ATTR_ENTITY_ID: "sensor.reg_number_plug_state", ATTR_ICON: "mdi:power-plug", ATTR_STATE: "plugged", @@ -340,7 +334,6 @@ MOCK_VEHICLES = { ], Platform.SELECT: [ { - ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_MODE, ATTR_ENTITY_ID: "select.reg_number_charge_mode", ATTR_ICON: "mdi:calendar-clock", ATTR_OPTIONS: ["always", "always_charging", "schedule_mode"], @@ -390,7 +383,6 @@ MOCK_VEHICLES = { ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS, }, { - ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_STATE, ATTR_ENTITY_ID: "sensor.reg_number_charge_state", ATTR_ICON: "mdi:flash-off", ATTR_STATE: "charge_error", @@ -443,7 +435,6 @@ MOCK_VEHICLES = { ATTR_UNIQUE_ID: "vf1aaaaa555777999_hvac_last_activity", }, { - ATTR_DEVICE_CLASS: DEVICE_CLASS_PLUG_STATE, ATTR_ENTITY_ID: "sensor.reg_number_plug_state", ATTR_ICON: "mdi:power-plug-off", ATTR_STATE: "unplugged", @@ -559,7 +550,6 @@ MOCK_VEHICLES = { ], Platform.SELECT: [ { - ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_MODE, ATTR_ENTITY_ID: "select.reg_number_charge_mode", ATTR_ICON: "mdi:calendar-remove", ATTR_OPTIONS: ["always", "always_charging", "schedule_mode"], @@ -609,7 +599,6 @@ MOCK_VEHICLES = { ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS, }, { - ATTR_DEVICE_CLASS: DEVICE_CLASS_CHARGE_STATE, ATTR_ENTITY_ID: "sensor.reg_number_charge_state", ATTR_ICON: "mdi:flash", ATTR_STATE: "charge_in_progress", @@ -659,7 +648,6 @@ MOCK_VEHICLES = { ATTR_UNIT_OF_MEASUREMENT: LENGTH_KILOMETERS, }, { - ATTR_DEVICE_CLASS: DEVICE_CLASS_PLUG_STATE, ATTR_ENTITY_ID: "sensor.reg_number_plug_state", ATTR_ICON: "mdi:power-plug", ATTR_STATE: "plugged",