2909e1c4fe
* Correct handling of power_factor ElectricalMeasurement attribute The Zigbee Cluster Library defines PowerFactor as an int8 with value supported from -100 to 100. Currently the zha sensor handler attempts to apply the ac_power_divisor and ac_power_multiplier formatters against the attribute value, the spec outlines that this should not be the case. The impact of the current code is that quirks not using the default values of 1 are multiplying/dividing power and power factor values prior to updating the cluster attribute. This results in either a non-conformant power_factor e.g. the value was multiplied by 10 so that an ac_power_divider of 10 could be used, or the power readings sacrificing a point of measurement for lower readings. Two quirks currently use this workaround: * ts0601_din_power.py * ts0601_rcbo.py * Update ZHA Metering formatter to perform None check on _div_mul_prefix To address feedback: https://github.com/home-assistant/core/pull/107641#discussion_r1447547054 * _div_mul_prefix needs self reference * Simplify None check for _div_mul_prefix Co-authored-by: Joakim Plate <elupus@ecce.se> * Updates to formatting and CI test typing fix * Use ' | ' in place of Union * Add tests for power_factor sensor --------- Co-authored-by: Joakim Plate <elupus@ecce.se> |
||
|---|---|---|
| .. | ||
| auth | ||
| components | ||
| fixtures | ||
| hassfest | ||
| helpers | ||
| pylint | ||
| resources | ||
| scripts | ||
| snapshots | ||
| test_util | ||
| testing_config | ||
| util | ||
| __init__.py | ||
| common.py | ||
| conftest.py | ||
| ignore_uncaught_exceptions.py | ||
| patch_time.py | ||
| ruff.toml | ||
| syrupy.py | ||
| test_bootstrap.py | ||
| test_config.py | ||
| test_config_entries.py | ||
| test_const.py | ||
| test_core.py | ||
| test_data_entry_flow.py | ||
| test_exceptions.py | ||
| test_loader.py | ||
| test_main.py | ||
| test_requirements.py | ||
| test_runner.py | ||
| test_setup.py | ||
| test_test_fixtures.py | ||
| typing.py | ||