* Remove unnecessary exception re-wraps * Preserve exception chains on re-raise We slap "from cause" to almost all possible cases here. In some cases it could conceivably be better to do "from None" if we really want to hide the cause. However those should be in the minority, and "from cause" should be an improvement over the corresponding raise without a "from" in all cases anyway. The only case where we raise from None here is in plex, where the exception for an original invalid SSL cert is not the root cause for failure to validate a newly fetched one. Follow local convention on exception variable names if there is a consistent one, otherwise `err` to match with majority of codebase. * Fix mistaken re-wrap in homematicip_cloud/hap.py Missed the difference between HmipConnectionError and HmipcConnectionError. * Do not hide original error on plex new cert validation error Original is not the cause for the new one, but showing old in the traceback is useful nevertheless.
49 lines
1.4 KiB
Python
49 lines
1.4 KiB
Python
"""Define Guardian-specific utilities."""
|
|
import asyncio
|
|
from datetime import timedelta
|
|
from typing import Awaitable, Callable
|
|
|
|
from aioguardian import Client
|
|
from aioguardian.errors import GuardianError
|
|
|
|
from homeassistant.core import HomeAssistant
|
|
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed
|
|
|
|
from .const import LOGGER
|
|
|
|
DEFAULT_UPDATE_INTERVAL = timedelta(seconds=30)
|
|
|
|
|
|
class GuardianDataUpdateCoordinator(DataUpdateCoordinator[dict]):
|
|
"""Define an extended DataUpdateCoordinator with some Guardian goodies."""
|
|
|
|
def __init__(
|
|
self,
|
|
hass: HomeAssistant,
|
|
*,
|
|
client: Client,
|
|
api_name: str,
|
|
api_coro: Callable[..., Awaitable],
|
|
api_lock: asyncio.Lock,
|
|
valve_controller_uid: str,
|
|
):
|
|
"""Initialize."""
|
|
super().__init__(
|
|
hass,
|
|
LOGGER,
|
|
name=f"{valve_controller_uid}_{api_name}",
|
|
update_interval=DEFAULT_UPDATE_INTERVAL,
|
|
)
|
|
|
|
self._api_coro = api_coro
|
|
self._api_lock = api_lock
|
|
self._client = client
|
|
|
|
async def _async_update_data(self) -> dict:
|
|
"""Execute a "locked" API request against the valve controller."""
|
|
async with self._api_lock, self._client:
|
|
try:
|
|
resp = await self._api_coro()
|
|
except GuardianError as err:
|
|
raise UpdateFailed(err) from err
|
|
return resp["data"]
|