* Add pylint plugin to check if coordinator is placed in its own module
* Remove unintended changes
* Remove pylint disable and let CI only fail on W,E,F
* Make check conventional
* Apply review suggestion
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
* Use option instead
* Remove pylint arguments from pre-commit
* Partially revert "Remove pylint disable and let CI only fail on W,E,F"
---------
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
* Remove unnecessary exception re-wraps
* Preserve exception chains on re-raise
We slap "from cause" to almost all possible cases here. In some cases it
could conceivably be better to do "from None" if we really want to hide
the cause. However those should be in the minority, and "from cause"
should be an improvement over the corresponding raise without a "from"
in all cases anyway.
The only case where we raise from None here is in plex, where the
exception for an original invalid SSL cert is not the root cause for
failure to validate a newly fetched one.
Follow local convention on exception variable names if there is a
consistent one, otherwise `err` to match with majority of codebase.
* Fix mistaken re-wrap in homematicip_cloud/hap.py
Missed the difference between HmipConnectionError and
HmipcConnectionError.
* Do not hide original error on plex new cert validation error
Original is not the cause for the new one, but showing old in the
traceback is useful nevertheless.
