From fe56844a3aa70ad7c63d19b9562b784cfc667900 Mon Sep 17 00:00:00 2001 From: John Arild Berentsen Date: Thu, 5 Apr 2018 11:14:15 +0200 Subject: [PATCH] Bugfix: Zwave Print_node to logfile instead of console (#13302) * Print to logfile instead of console * Review changes * Typo --- homeassistant/components/zwave/__init__.py | 6 ++---- tests/components/zwave/test_init.py | 16 +++++++--------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/homeassistant/components/zwave/__init__.py b/homeassistant/components/zwave/__init__.py index a85160e8bde..02d2b574592 100644 --- a/homeassistant/components/zwave/__init__.py +++ b/homeassistant/components/zwave/__init__.py @@ -182,10 +182,8 @@ def nice_print_node(node): node_dict['values'] = {value_id: _obj_to_dict(value) for value_id, value in node.values.items()} - print("\n\n\n") - print("FOUND NODE", node.product_name) - pprint(node_dict) - print("\n\n\n") + _LOGGER.info("FOUND NODE %s \n" + "%s", node.product_name, node_dict) def get_config_value(node, value_index, tries=5): diff --git a/tests/components/zwave/test_init.py b/tests/components/zwave/test_init.py index bb073459b48..004e5e95ca0 100644 --- a/tests/components/zwave/test_init.py +++ b/tests/components/zwave/test_init.py @@ -1094,20 +1094,18 @@ class TestZWaveServices(unittest.TestCase): assert mock_logger.info.mock_calls[0][1][3] == 2345 def test_print_node(self): - """Test zwave print_config_parameter service.""" - node1 = MockNode(node_id=14) - node2 = MockNode(node_id=15) - self.zwave_network.nodes = {14: node1, 15: node2} + """Test zwave print_node_parameter service.""" + node = MockNode(node_id=14) - with patch.object(zwave, 'pprint') as mock_pprint: + self.zwave_network.nodes = {14: node} + + with self.assertLogs(level='INFO') as mock_logger: self.hass.services.call('zwave', 'print_node', { - const.ATTR_NODE_ID: 15, + const.ATTR_NODE_ID: 14 }) self.hass.block_till_done() - assert mock_pprint.called - assert len(mock_pprint.mock_calls) == 1 - assert mock_pprint.mock_calls[0][1][0]['node_id'] == 15 + self.assertIn("FOUND NODE ", mock_logger.output[1]) def test_set_wakeup(self): """Test zwave set_wakeup service."""