evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Disallow automation.trigger without entity_id (#14724)

Browse source
This commit is contained in:
Anders Melchiorsen 2018-06-01 16:27:12 +02:00 • committed by Paulus Schoutsen
parent f6eb9e79d5
commit fcbc399809
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/automation/__init__.py
View file

@ -98,7 +98,7 @@ SERVICE_SCHEMA = vol.Schema({
}) })
TRIGGER_SERVICE_SCHEMA = vol.Schema({ TRIGGER_SERVICE_SCHEMA = vol.Schema({
vol.Optional(ATTR_ENTITY_ID): cv.entity_ids, vol.Required(ATTR_ENTITY_ID): cv.entity_ids,
vol.Optional(ATTR_VARIABLES, default={}): dict, vol.Optional(ATTR_VARIABLES, default={}): dict,
}) })

5
tests/components/automation/test_init.py
View file

@ -207,6 +207,7 @@ class TestAutomation(unittest.TestCase):
"""Test triggers.""" """Test triggers."""
assert setup_component(self.hass, automation.DOMAIN, { assert setup_component(self.hass, automation.DOMAIN, {
automation.DOMAIN: { automation.DOMAIN: {
'alias': 'test',
'trigger': [ 'trigger': [
{ {
'platform': 'event', 'platform': 'event',
@ -228,7 +229,9 @@ class TestAutomation(unittest.TestCase):
self.hass.block_till_done() self.hass.block_till_done()
assert len(self.calls) == 0 assert len(self.calls) == 0
self.hass.services.call('automation', 'trigger', blocking=True) self.hass.services.call('automation', 'trigger',
{'entity_id': 'automation.test'},
blocking=True)
self.hass.block_till_done() self.hass.block_till_done()
assert len(self.calls) == 1 assert len(self.calls) == 1