evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

On-demand update of swiss public transport sensor (#16723)

Browse source 
* Sensor values to be updated only when required (only after the train has crossed).
Looking at the documentation on https://transport.opendata.ch/docs.html, delay information is available only on stationboard, so no need to query often if there is no "real"time info.

* Bumping up version of python_opendata_transport to 0.1.4 in order to catch client errors like throttling rejection (HTTP 429)

* pleasing the hound

* bumping python_opendata_transport to 0.1.4
This commit is contained in:
Vikram Gorla 2018-09-20 08:45:16 +02:00 • committed by Fabian Affolter
parent 27eede724c
commit fcb84d951e
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
homeassistant/components/sensor/swiss_public_transport.py
View file

@ -16,7 +16,7 @@ import homeassistant.helpers.config_validation as cv
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
import homeassistant.util.dt as dt_util import homeassistant.util.dt as dt_util
REQUIREMENTS = ['python_opendata_transport==0.1.3'] REQUIREMENTS = ['python_opendata_transport==0.1.4']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
@ -80,6 +80,7 @@ class SwissPublicTransportSensor(Entity):
self._name = name self._name = name
self._from = start self._from = start
self._to = destination self._to = destination
self._remaining_time = ""
@property @property
def name(self): def name(self):
@ -98,7 +99,7 @@ class SwissPublicTransportSensor(Entity):
if self._opendata is None: if self._opendata is None:
return return
remaining_time = dt_util.parse_datetime( self._remaining_time = dt_util.parse_datetime(
self._opendata.connections[0]['departure']) -\ self._opendata.connections[0]['departure']) -\
dt_util.as_local(dt_util.utcnow()) dt_util.as_local(dt_util.utcnow())
@ -111,7 +112,7 @@ class SwissPublicTransportSensor(Entity):
ATTR_DEPARTURE_TIME2: self._opendata.connections[2]['departure'], ATTR_DEPARTURE_TIME2: self._opendata.connections[2]['departure'],
ATTR_START: self._opendata.from_name, ATTR_START: self._opendata.from_name,
ATTR_TARGET: self._opendata.to_name, ATTR_TARGET: self._opendata.to_name,
ATTR_REMAINING_TIME: '{}'.format(remaining_time), ATTR_REMAINING_TIME: '{}'.format(self._remaining_time),
ATTR_ATTRIBUTION: CONF_ATTRIBUTION, ATTR_ATTRIBUTION: CONF_ATTRIBUTION,
} }
return attr return attr
@ -126,6 +127,7 @@ class SwissPublicTransportSensor(Entity):
from opendata_transport.exceptions import OpendataTransportError from opendata_transport.exceptions import OpendataTransportError
try: try:
if self._remaining_time.total_seconds() < 0:
await self._opendata.async_get_data() await self._opendata.async_get_data()
except OpendataTransportError: except OpendataTransportError:
_LOGGER.error("Unable to retrieve data from transport.opendata.ch") _LOGGER.error("Unable to retrieve data from transport.opendata.ch")

2
requirements_all.txt
View file

@ -1170,7 +1170,7 @@ python-vlc==1.1.2
python-wink==1.10.1 python-wink==1.10.1
# homeassistant.components.sensor.swiss_public_transport # homeassistant.components.sensor.swiss_public_transport
python_opendata_transport==0.1.3 python_opendata_transport==0.1.4
# homeassistant.components.zwave # homeassistant.components.zwave
python_openzwave==0.4.9 python_openzwave==0.4.9