evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

IGD review fixes (#17400)

Browse source 
* Fix discovery-dependency for upnp

* Only delete port mappings on EVENT_HOMEASSISTANT_STOP + refactoring MockDevice

* Call and store local_ip from async_setup

* Don't depend on http-component

* Remove discovery dependency
This commit is contained in:
Steven Looman 2018-10-23 21:52:01 +02:00 • committed by Paulus Schoutsen
parent 0f69be117f
commit fc8af22191
3 changed files with 118 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

9
homeassistant/components/upnp/device.py
View file

@ -6,7 +6,6 @@ import aiohttp
from homeassistant.helpers.aiohttp_client import async_get_clientsession
from homeassistant.helpers.typing import HomeAssistantType
from homeassistant.util import get_local_ip
from .const import LOGGER as _LOGGER
@ -51,15 +50,13 @@ class Device:
"""Get the name."""
return self._igd_device.name
async def async_add_port_mappings(self, ports, local_ip=None):
async def async_add_port_mappings(self, ports, local_ip):
"""Add port mappings."""
# determine local ip, ensure sane IP
if local_ip is None:
local_ip = get_local_ip()
if local_ip == '127.0.0.1':
_LOGGER.error(
'Could not create port mapping, our IP is 127.0.0.1')
# determine local ip, ensure sane IP
local_ip = IPv4Address(local_ip)
# create port mappings