evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove callback decorators where unneeded (#90478)

Browse source 
* Remove callback decorators where unneeded

* revert extra replace
This commit is contained in:
Raman Gupta 2023-03-29 18:04:39 -04:00 • committed by GitHub
parent 93d1961aae
commit fc78290e2f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
homeassistant/components/zwave_js/api.py
View file

@ -82,8 +82,8 @@ from .const import (
from .helpers import (
async_enable_statistics,
async_get_node_from_device_id,
async_update_data_collection_preference,
get_device_id,
update_data_collection_preference,
)
DATA_UNSUBSCRIBE = "unsubs"
@ -1860,7 +1860,7 @@ async def websocket_update_data_collection_preference(
) -> None:
"""Update preference for data collection and enable/disable collection."""
opted_in = msg[OPTED_IN]
update_data_collection_preference(hass, entry, opted_in)
async_update_data_collection_preference(hass, entry, opted_in)
if opted_in:
await async_enable_statistics(driver)

9
homeassistant/components/zwave_js/helpers.py
View file

@ -92,7 +92,6 @@ def value_matches_matcher(
)
@callback
def get_value_id_from_unique_id(unique_id: str) -> str | None:
"""Get the value ID and optional state key from a unique ID.
@ -106,7 +105,6 @@ def get_value_id_from_unique_id(unique_id: str) -> str | None:
return None
@callback
def get_state_key_from_unique_id(unique_id: str) -> int | None:
"""Get the state key from a unique ID."""
# If the unique ID has more than two parts, it's a special unique ID. If the last
@ -119,7 +117,6 @@ def get_state_key_from_unique_id(unique_id: str) -> int | None:
return None
@callback
def get_value_of_zwave_value(value: ZwaveValue | None) -> Any | None:
"""Return the value of a ZwaveValue."""
return value.value if value else None
@ -132,7 +129,7 @@ async def async_enable_statistics(driver: Driver) -> None:
@callback
def update_data_collection_preference(
def async_update_data_collection_preference(
hass: HomeAssistant, entry: ConfigEntry, preference: bool
) -> None:
"""Update data collection preference on config entry."""
@ -141,7 +138,6 @@ def update_data_collection_preference(
hass.config_entries.async_update_entry(entry, data=new_data)
@callback
def get_valueless_base_unique_id(driver: Driver, node: ZwaveNode) -> str:
"""Return the base unique ID for an entity that is not based on a value."""
return f"{driver.controller.home_id}.{node.node_id}"
@ -152,13 +148,11 @@ def get_unique_id(driver: Driver, value_id: str) -> str:
return f"{driver.controller.home_id}.{value_id}"
@callback
def get_device_id(driver: Driver, node: ZwaveNode) -> tuple[str, str]:
"""Get device registry identifier for Z-Wave node."""
return (DOMAIN, f"{driver.controller.home_id}-{node.node_id}")
@callback
def get_device_id_ext(driver: Driver, node: ZwaveNode) -> tuple[str, str] | None:
"""Get extended device registry identifier for Z-Wave node."""
if None in (node.manufacturer_id, node.product_type, node.product_id):
@ -171,7 +165,6 @@ def get_device_id_ext(driver: Driver, node: ZwaveNode) -> tuple[str, str] | None
)
@callback
def get_home_and_node_id_from_device_entry(
device_entry: dr.DeviceEntry,
) -> tuple[str, int] | None: