evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Warn on undefined variables in templates (#48140)

Browse source 
* Warn on undefined variables in templates

* Add test

* fix tests

* fix tests
This commit is contained in:
Erik Montnemery 2021-03-20 15:16:04 +01:00 • committed by GitHub
parent 863f75e65e
commit f8755a52c2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/components/influxdb/test_sensor.py
View file

@ -442,7 +442,7 @@ async def test_error_querying_influx(
@pytest.mark.parametrize(
"mock_client, config_ext, queries, set_query_mock, make_resultset",
"mock_client, config_ext, queries, set_query_mock, make_resultset, key",
[
(
DEFAULT_API_VERSION,
@ -459,6 +459,7 @@ async def test_error_querying_influx(
},
_set_query_mock_v1,
_make_v1_resultset,
"where",
),
(
API_VERSION_2,
@ -466,12 +467,13 @@ async def test_error_querying_influx(
{"queries_flux": [{"name": "test", "query": "{{ illegal.template }}"}]},
_set_query_mock_v2,
_make_v2_resultset,
"query",
),
],
indirect=["mock_client"],
)
async def test_error_rendering_template(
hass, caplog, mock_client, config_ext, queries, set_query_mock, make_resultset
hass, caplog, mock_client, config_ext, queries, set_query_mock, make_resultset, key
):
"""Test behavior of sensor with error rendering template."""
set_query_mock(mock_client, return_value=make_resultset(42))
@ -479,7 +481,15 @@ async def test_error_rendering_template(
sensors = await _setup(hass, config_ext, queries, ["sensor.test"])
assert sensors[0].state == STATE_UNKNOWN
assert (
len([record for record in caplog.records if record.levelname == "ERROR"]) == 1
len(
[
record
for record in caplog.records
if record.levelname == "ERROR"
and f"Could not render {key} template" in record.msg
]
)
== 1
)