evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add missing support for jewish_calendar.omer_count sensor (#24958)

Browse source 
* Add missing support for omer_count to jewish_calendar

* Add tests for omer sensor

* Add tests for omer after tzeit hakochavim

* Lint fixes
This commit is contained in:
arigilder 2019-07-09 05:58:57 -04:00 • committed by Martin Hjelmare
parent 07b635e7aa
commit f3e542542a
2 changed files with 55 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/jewish_calendar/sensor.py
View file

@ -185,6 +185,8 @@ class JewishCalSensor(Entity):
self._state = times.havdalah self._state = times.havdalah
elif self.type == 'issur_melacha_in_effect': elif self.type == 'issur_melacha_in_effect':
self._state = make_zmanim(now).issur_melacha_in_effect self._state = make_zmanim(now).issur_melacha_in_effect
elif self.type == 'omer_count':
self._state = date.omer_day
else: else:
times = make_zmanim(today).zmanim times = make_zmanim(today).zmanim
self._state = times[self.type].time() self._state = times[self.type].time()

53
tests/components/jewish_calendar/test_sensor.py
View file

@ -445,3 +445,56 @@ class TestJewishCalenderSensor():
sensor.async_update(), sensor.async_update(),
self.hass.loop).result() self.hass.loop).result()
assert sensor.state == result assert sensor.state == result
omer_params = [
make_nyc_test_params(dt(2019, 4, 21, 0, 0), 1),
make_jerusalem_test_params(dt(2019, 4, 21, 0, 0), 1),
make_nyc_test_params(dt(2019, 4, 21, 23, 0), 2),
make_jerusalem_test_params(dt(2019, 4, 21, 23, 0), 2),
make_nyc_test_params(dt(2019, 5, 23, 0, 0), 33),
make_jerusalem_test_params(dt(2019, 5, 23, 0, 0), 33),
make_nyc_test_params(dt(2019, 6, 8, 0, 0), 49),
make_jerusalem_test_params(dt(2019, 6, 8, 0, 0), 49),
make_nyc_test_params(dt(2019, 6, 9, 0, 0), 0),
make_jerusalem_test_params(dt(2019, 6, 9, 0, 0), 0),
make_nyc_test_params(dt(2019, 1, 1, 0, 0), 0),
make_jerusalem_test_params(dt(2019, 1, 1, 0, 0), 0),
]
omer_test_ids = [
"nyc_first_day_of_omer",
"israel_first_day_of_omer",
"nyc_first_day_of_omer_after_tzeit",
"israel_first_day_of_omer_after_tzeit",
"nyc_lag_baomer",
"israel_lag_baomer",
"nyc_last_day_of_omer",
"israel_last_day_of_omer",
"nyc_shavuot_no_omer",
"israel_shavuot_no_omer",
"nyc_jan_1st_no_omer",
"israel_jan_1st_no_omer",
]
@pytest.mark.parametrize(["now", "candle_lighting", "havdalah", "diaspora",
"tzname", "latitude", "longitude", "result"],
omer_params, ids=omer_test_ids)
def test_omer_sensor(self, now, candle_lighting, havdalah,
diaspora, tzname, latitude, longitude,
result):
"""Test Omer Count sensor output."""
time_zone = get_time_zone(tzname)
set_default_time_zone(time_zone)
test_time = time_zone.localize(now)
self.hass.config.latitude = latitude
self.hass.config.longitude = longitude
sensor = JewishCalSensor(
name='test', language='english',
sensor_type='omer_count',
latitude=latitude, longitude=longitude,
timezone=time_zone, diaspora=diaspora)
sensor.hass = self.hass
with patch('homeassistant.util.dt.now', return_value=test_time):
run_coroutine_threadsafe(
sensor.async_update(),
self.hass.loop).result()
assert sensor.state == result