From f1fb28aad55eebf1a0774cee47bb5f634435f2b5 Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Thu, 24 Aug 2023 01:01:58 +0200 Subject: [PATCH] Use snapshot assertion for ESPHome diagnostics test (#98913) --- tests/components/esphome/conftest.py | 1 + .../esphome/snapshots/test_diagnostics.ambr | 26 +++++++++++++++++++ tests/components/esphome/test_diagnostics.py | 18 +++---------- 3 files changed, 30 insertions(+), 15 deletions(-) create mode 100644 tests/components/esphome/snapshots/test_diagnostics.ambr diff --git a/tests/components/esphome/conftest.py b/tests/components/esphome/conftest.py index f0fe2d9ccb0..6b06545a06b 100644 --- a/tests/components/esphome/conftest.py +++ b/tests/components/esphome/conftest.py @@ -62,6 +62,7 @@ def mock_config_entry(hass) -> MockConfigEntry: """Return the default mocked config entry.""" config_entry = MockConfigEntry( title="ESPHome Device", + entry_id="08d821dc059cf4f645cb024d32c8e708", domain=DOMAIN, data={ CONF_HOST: "192.168.1.2", diff --git a/tests/components/esphome/snapshots/test_diagnostics.ambr b/tests/components/esphome/snapshots/test_diagnostics.ambr new file mode 100644 index 00000000000..d8de8f06bc6 --- /dev/null +++ b/tests/components/esphome/snapshots/test_diagnostics.ambr @@ -0,0 +1,26 @@ +# serializer version: 1 +# name: test_diagnostics + dict({ + 'config': dict({ + 'data': dict({ + 'device_name': 'test', + 'host': '192.168.1.2', + 'noise_psk': '**REDACTED**', + 'password': '**REDACTED**', + 'port': 6053, + }), + 'disabled_by': None, + 'domain': 'esphome', + 'entry_id': '08d821dc059cf4f645cb024d32c8e708', + 'options': dict({ + }), + 'pref_disable_new_entities': False, + 'pref_disable_polling': False, + 'source': 'user', + 'title': 'ESPHome Device', + 'unique_id': '11:22:33:44:55:aa', + 'version': 1, + }), + 'dashboard': 'mock-slug', + }) +# --- diff --git a/tests/components/esphome/test_diagnostics.py b/tests/components/esphome/test_diagnostics.py index 025c5bcaae8..6000b270d87 100644 --- a/tests/components/esphome/test_diagnostics.py +++ b/tests/components/esphome/test_diagnostics.py @@ -1,12 +1,8 @@ """Tests for the diagnostics data provided by the ESPHome integration.""" +from syrupy import SnapshotAssertion - -from homeassistant.components.esphome.const import CONF_DEVICE_NAME, CONF_NOISE_PSK -from homeassistant.const import CONF_HOST, CONF_PASSWORD, CONF_PORT from homeassistant.core import HomeAssistant -from . import DASHBOARD_SLUG - from tests.common import MockConfigEntry from tests.components.diagnostics import get_diagnostics_for_config_entry from tests.typing import ClientSessionGenerator @@ -18,17 +14,9 @@ async def test_diagnostics( init_integration: MockConfigEntry, enable_bluetooth: None, mock_dashboard, + snapshot: SnapshotAssertion, ) -> None: """Test diagnostics for config entry.""" result = await get_diagnostics_for_config_entry(hass, hass_client, init_integration) - assert isinstance(result, dict) - assert result["config"]["data"] == { - CONF_DEVICE_NAME: "test", - CONF_HOST: "192.168.1.2", - CONF_PORT: 6053, - CONF_PASSWORD: "**REDACTED**", - CONF_NOISE_PSK: "**REDACTED**", - } - assert result["config"]["unique_id"] == "11:22:33:44:55:aa" - assert result["dashboard"] == DASHBOARD_SLUG + assert result == snapshot