evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add resolution to Amcrest camera unique id (#56207)

Browse source 
Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>
This commit is contained in:
Sean Vig 2021-09-30 07:38:18 -04:00 • committed by GitHub
parent dd52ec78c7
commit f18e4bab60
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 42 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
homeassistant/components/amcrest/binary_sensor.py
View file

@ -170,7 +170,7 @@ class AmcrestBinarySensor(BinarySensorEntity):
"""Initialize entity."""
self._signal_name = name
self._api = device.api
self._channel = 0 # Used in unique id, reserved for future use
self._channel = device.channel
self.entity_description: AmcrestSensorEntityDescription = entity_description
self._attr_name = f"{name} {entity_description.name}"
@ -195,14 +195,13 @@ class AmcrestBinarySensor(BinarySensorEntity):
return
_LOGGER.debug(_UPDATE_MSG, self.name)
self._update_unique_id()
if self._api.available:
# Send a command to the camera to test if we can still communicate with it.
# Override of Http.command() in __init__.py will set self._api.available
# accordingly.
with suppress(AmcrestError):
self._api.current_time # pylint: disable=pointless-statement
self._update_unique_id()
self._attr_is_on = self._api.available
def _update_others(self) -> None:
@ -210,7 +209,11 @@ class AmcrestBinarySensor(BinarySensorEntity):
return
_LOGGER.debug(_UPDATE_MSG, self.name)
self._update_unique_id()
try:
self._update_unique_id()
except AmcrestError as error:
log_update_error(_LOGGER, "update", self.name, "binary sensor", error)
return
event_code = self.entity_description.event_code
if event_code is None:
@ -221,6 +224,7 @@ class AmcrestBinarySensor(BinarySensorEntity):
self._attr_is_on = len(self._api.event_channels_happened(event_code)) > 0
except AmcrestError as error:
log_update_error(_LOGGER, "update", self.name, "binary sensor", error)
return
def _update_unique_id(self) -> None:
"""Set the unique id."""