evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make zwave_js value updated event logic more performant (#52997)

Browse source
This commit is contained in:
Raman Gupta 2021-07-14 02:56:10 -04:00 • committed by GitHub
parent 7b7062dded
commit f13a15f2a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

19
homeassistant/components/zwave_js/__init__.py
View file

@ -141,7 +141,7 @@ async def async_setup_entry( # noqa: C901
if device.id not in registered_unique_ids: if device.id not in registered_unique_ids:
registered_unique_ids[device.id] = defaultdict(set) registered_unique_ids[device.id] = defaultdict(set)
value_updates_disc_info = [] value_updates_disc_info: dict[str, ZwaveDiscoveryInfo] = {}
# run discovery on all node values and create/update entities # run discovery on all node values and create/update entities
for disc_info in async_discover_values(node): for disc_info in async_discover_values(node):
@ -173,7 +173,7 @@ async def async_setup_entry( # noqa: C901
# Capture discovery info for values we want to watch for updates # Capture discovery info for values we want to watch for updates
if disc_info.assumed_state: if disc_info.assumed_state:
value_updates_disc_info.append(disc_info) value_updates_disc_info[disc_info.primary_value.value_id] = disc_info
# add listener for value updated events if necessary # add listener for value updated events if necessary
if value_updates_disc_info: if value_updates_disc_info:
@ -313,19 +313,14 @@ async def async_setup_entry( # noqa: C901
@callback @callback
def async_on_value_updated( def async_on_value_updated(
value_updates_disc_info: list[ZwaveDiscoveryInfo], value: Value value_updates_disc_info: dict[str, ZwaveDiscoveryInfo], value: Value
) -> None: ) -> None:
"""Fire value updated event.""" """Fire value updated event."""
# Get the discovery info for the value that was updated. If we can't # Get the discovery info for the value that was updated. If there is
# find the discovery info, we don't need to fire an event # no discovery info for this value, we don't need to fire an event
try: if value.value_id not in value_updates_disc_info:
disc_info = next(
disc_info
for disc_info in value_updates_disc_info
if disc_info.primary_value.value_id == value.value_id
)
except StopIteration:
return return
disc_info = value_updates_disc_info[value.value_id]
device = dev_reg.async_get_device({get_device_id(client, value.node)}) device = dev_reg.async_get_device({get_device_id(client, value.node)})