From effa9940ff185289dbad9ab8c88b72f7067184f5 Mon Sep 17 00:00:00 2001 From: Erik Montnemery Date: Mon, 28 Nov 2022 15:42:08 +0100 Subject: [PATCH] Save migrated store data (#82523) --- homeassistant/helpers/storage.py | 1 + tests/helpers/test_storage.py | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/homeassistant/helpers/storage.py b/homeassistant/helpers/storage.py index 6819a1eb48b..44a0da7866b 100644 --- a/homeassistant/helpers/storage.py +++ b/homeassistant/helpers/storage.py @@ -177,6 +177,7 @@ class Store(Generic[_T]): if data["version"] != self.version: raise stored = data["data"] + await self.async_save(stored) return stored diff --git a/tests/helpers/test_storage.py b/tests/helpers/test_storage.py index ca5cb92bfd5..0fcfbc46ef9 100644 --- a/tests/helpers/test_storage.py +++ b/tests/helpers/test_storage.py @@ -394,13 +394,13 @@ async def test_migration(hass, hass_storage, store_v_1_2): } assert calls == 0 - legacy_store = CustomStore(hass, 2, store_v_1_2.key, minor_version=1) - data = await legacy_store.async_load() + custom_store = CustomStore(hass, 2, store_v_1_2.key, minor_version=1) + data = await custom_store.async_load() assert calls == 1 assert hass_storage[store_v_1_2.key]["data"] == data - await legacy_store.async_save(MOCK_DATA) - assert hass_storage[legacy_store.key] == { + # Assert the migrated data has been saved + assert hass_storage[custom_store.key] == { "key": MOCK_KEY, "version": 2, "minor_version": 1, @@ -433,7 +433,7 @@ async def test_legacy_migration(hass, hass_storage, store_v_1_2): assert calls == 1 assert hass_storage[store_v_1_2.key]["data"] == data - await legacy_store.async_save(MOCK_DATA) + # Assert the migrated data has been saved assert hass_storage[legacy_store.key] == { "key": MOCK_KEY, "version": 2,