evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cleanups in Twinkly code (#64139)

Browse source 
* Cleanup Twinkly code

* Add codeowner'

* Change const names
This commit is contained in:
Rob Bierbooms 2022-01-14 22:07:15 +01:00 • committed by GitHub
parent e609f196bc
commit efe34c8d13
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 124 additions and 194 deletions
Download patch file Download diff file Expand all files Collapse all files

38
tests/components/twinkly/test_config_flow.py
View file

@ -4,10 +4,10 @@ from unittest.mock import patch
from homeassistant import config_entries
from homeassistant.components import dhcp
from homeassistant.components.twinkly.const import (
CONF_ENTRY_HOST,
CONF_ENTRY_ID,
CONF_ENTRY_MODEL,
CONF_ENTRY_NAME,
CONF_HOST,
CONF_ID,
CONF_MODEL,
CONF_NAME,
DOMAIN as TWINKLY_DOMAIN,
)
@ -31,12 +31,12 @@ async def test_invalid_host(hass):
assert result["errors"] == {}
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
{CONF_ENTRY_HOST: "dummy"},
{CONF_HOST: "dummy"},
)
assert result["type"] == "form"
assert result["step_id"] == "user"
assert result["errors"] == {CONF_ENTRY_HOST: "cannot_connect"}
assert result["errors"] == {CONF_HOST: "cannot_connect"}
async def test_success_flow(hass):
@ -55,16 +55,16 @@ async def test_success_flow(hass):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
{CONF_ENTRY_HOST: "dummy"},
{CONF_HOST: "dummy"},
)
assert result["type"] == "create_entry"
assert result["title"] == client.id
assert result["data"] == {
CONF_ENTRY_HOST: "dummy",
CONF_ENTRY_ID: client.id,
CONF_ENTRY_NAME: client.id,
CONF_ENTRY_MODEL: TEST_MODEL,
CONF_HOST: "dummy",
CONF_ID: client.id,
CONF_NAME: client.id,
CONF_MODEL: TEST_MODEL,
}
@ -114,10 +114,10 @@ async def test_dhcp_success(hass):
assert result["type"] == "create_entry"
assert result["title"] == client.id
assert result["data"] == {
CONF_ENTRY_HOST: "1.2.3.4",
CONF_ENTRY_ID: client.id,
CONF_ENTRY_NAME: client.id,
CONF_ENTRY_MODEL: TEST_MODEL,
CONF_HOST: "1.2.3.4",
CONF_ID: client.id,
CONF_NAME: client.id,
CONF_MODEL: TEST_MODEL,
}
@ -128,10 +128,10 @@ async def test_dhcp_already_exists(hass):
entry = MockConfigEntry(
domain=TWINKLY_DOMAIN,
data={
CONF_ENTRY_HOST: "1.2.3.4",
CONF_ENTRY_ID: client.id,
CONF_ENTRY_NAME: client.id,
CONF_ENTRY_MODEL: TEST_MODEL,
CONF_HOST: "1.2.3.4",
CONF_ID: client.id,
CONF_NAME: client.id,
CONF_MODEL: TEST_MODEL,
},
unique_id=client.id,
)