Mqtt cover toggle add stop function (#59233)

* Change existing toggle to add new function

* Fixed using old property method to using actual protected variable.

* Adding service tests to new cover toggle function

* Working on comments from Pull Request 59233

* Adjust existing tests to fit new fake cover setup

* MockCover is calling state method of MockEntity but should call it from CoverEntity

* using different entity to get back test coverage

tests/components/cover/test_init.py

@@ -1,5 +1,116 @@
 """The tests for Cover."""
 import homeassistant.components.cover as cover
+from homeassistant.const import (
+    ATTR_ENTITY_ID,
+    CONF_PLATFORM,
+    SERVICE_TOGGLE,
+    STATE_CLOSED,
+    STATE_CLOSING,
+    STATE_OPEN,
+    STATE_OPENING,
+)
+from homeassistant.setup import async_setup_component
+
+
+async def test_services(hass, enable_custom_integrations):
+    """Test the provided services."""
+    platform = getattr(hass.components, "test.cover")
+
+    platform.init()
+    assert await async_setup_component(
+        hass, cover.DOMAIN, {cover.DOMAIN: {CONF_PLATFORM: "test"}}
+    )
+    await hass.async_block_till_done()
+
+    # ent1 = cover without tilt and position
+    # ent2 = cover with position but no tilt
+    # ent3 = cover with simple tilt functions and no position
+    # ent4 = cover with all tilt functions but no position
+    # ent5 = cover with all functions
+    ent1, ent2, ent3, ent4, ent5 = platform.ENTITIES
+
+    # Test init all covers should be open
+    assert is_open(hass, ent1)
+    assert is_open(hass, ent2)
+    assert is_open(hass, ent3)
+    assert is_open(hass, ent4)
+    assert is_open(hass, ent5)
+
+    # call basic toggle services
+    await call_service(hass, SERVICE_TOGGLE, ent1)
+    await call_service(hass, SERVICE_TOGGLE, ent2)
+    await call_service(hass, SERVICE_TOGGLE, ent3)
+    await call_service(hass, SERVICE_TOGGLE, ent4)
+    await call_service(hass, SERVICE_TOGGLE, ent5)
+
+    # entities without stop should be closed and with stop should be closing
+    assert is_closed(hass, ent1)
+    assert is_closing(hass, ent2)
+    assert is_closed(hass, ent3)
+    assert is_closed(hass, ent4)
+    assert is_closing(hass, ent5)
+
+    # call basic toggle services and set different cover position states
+    await call_service(hass, SERVICE_TOGGLE, ent1)
+    set_cover_position(ent2, 0)
+    await call_service(hass, SERVICE_TOGGLE, ent2)
+    await call_service(hass, SERVICE_TOGGLE, ent3)
+    await call_service(hass, SERVICE_TOGGLE, ent4)
+    set_cover_position(ent5, 15)
+    await call_service(hass, SERVICE_TOGGLE, ent5)
+
+    # entities should be in correct state depending on the SUPPORT_STOP feature and cover position
+    assert is_open(hass, ent1)
+    assert is_closed(hass, ent2)
+    assert is_open(hass, ent3)
+    assert is_open(hass, ent4)
+    assert is_open(hass, ent5)
+
+    # call basic toggle services
+    await call_service(hass, SERVICE_TOGGLE, ent1)
+    await call_service(hass, SERVICE_TOGGLE, ent2)
+    await call_service(hass, SERVICE_TOGGLE, ent3)
+    await call_service(hass, SERVICE_TOGGLE, ent4)
+    await call_service(hass, SERVICE_TOGGLE, ent5)
+
+    # entities should be in correct state depending on the SUPPORT_STOP feature and cover position
+    assert is_closed(hass, ent1)
+    assert is_opening(hass, ent2)
+    assert is_closed(hass, ent3)
+    assert is_closed(hass, ent4)
+    assert is_opening(hass, ent5)
+
+
+def call_service(hass, service, ent):
+    """Call any service on entity."""
+    return hass.services.async_call(
+        cover.DOMAIN, service, {ATTR_ENTITY_ID: ent.entity_id}, blocking=True
+    )
+
+
+def set_cover_position(ent, position) -> None:
+    """Set a position value to a cover."""
+    ent._values["current_cover_position"] = position
+
+
+def is_open(hass, ent):
+    """Return if the cover is closed based on the statemachine."""
+    return hass.states.is_state(ent.entity_id, STATE_OPEN)
+
+
+def is_opening(hass, ent):
+    """Return if the cover is closed based on the statemachine."""
+    return hass.states.is_state(ent.entity_id, STATE_OPENING)
+
+
+def is_closed(hass, ent):
+    """Return if the cover is closed based on the statemachine."""
+    return hass.states.is_state(ent.entity_id, STATE_CLOSED)
+
+
+def is_closing(hass, ent):
+    """Return if the cover is closed based on the statemachine."""
+    return hass.states.is_state(ent.entity_id, STATE_CLOSING)
 
 
 def test_deprecated_base_class(caplog):