evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply bond python related feedback from a prior PR (#37821)

Browse source
This commit is contained in:
Eugene Prystupa 2020-07-13 17:07:35 -04:00 • committed by GitHub
parent 4aaf7c5432
commit ed3f25489e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
homeassistant/components/bond/utils.py
View file

@ -26,34 +26,28 @@ class BondDevice:
def supports_speed(self) -> bool:
"""Return True if this device supports any of the speed related commands."""
actions: List[str] = self._attrs["actions"]
return len([action for action in actions if action in [Actions.SET_SPEED]]) > 0
return bool([action for action in actions if action in [Actions.SET_SPEED]])
def supports_direction(self) -> bool:
"""Return True if this device supports any of the direction related commands."""
actions: List[str] = self._attrs["actions"]
return (
len(
[
action
for action in actions
if action in [Actions.SET_DIRECTION, Actions.TOGGLE_DIRECTION]
]
)
> 0
return bool(
[
action
for action in actions
if action in [Actions.SET_DIRECTION, Actions.TOGGLE_DIRECTION]
]
)
def supports_light(self) -> bool:
"""Return True if this device supports any of the light related commands."""
actions: List[str] = self._attrs["actions"]
return (
len(
[
action
for action in actions
if action in [Actions.TURN_LIGHT_ON, Actions.TOGGLE_LIGHT]
]
)
> 0
return bool(
[
action
for action in actions
if action in [Actions.TURN_LIGHT_ON, Actions.TOGGLE_LIGHT]
]
)

2
tests/components/bond/test_cover.py
View file

@ -33,7 +33,7 @@ async def test_entity_registry(hass: core.HomeAssistant):
await setup_platform(hass, COVER_DOMAIN, shades("name-1"))
registry: EntityRegistry = await hass.helpers.entity_registry.async_get_registry()
assert [key for key in registry.entities.keys()] == ["cover.name_1"]
assert [key for key in registry.entities] == ["cover.name_1"]
async def test_open_cover(hass: core.HomeAssistant):

2
tests/components/bond/test_fan.py
View file

@ -36,7 +36,7 @@ async def test_entity_registry(hass: core.HomeAssistant):
await setup_platform(hass, FAN_DOMAIN, ceiling_fan("name-1"))
registry: EntityRegistry = await hass.helpers.entity_registry.async_get_registry()
assert [key for key in registry.entities.keys()] == ["fan.name_1"]
assert [key for key in registry.entities] == ["fan.name_1"]
async def test_turn_on_fan(hass: core.HomeAssistant):

2
tests/components/bond/test_light.py
View file

@ -32,7 +32,7 @@ async def test_entity_registry(hass: core.HomeAssistant):
await setup_platform(hass, LIGHT_DOMAIN, ceiling_fan("name-1"))
registry: EntityRegistry = await hass.helpers.entity_registry.async_get_registry()
assert [key for key in registry.entities.keys()] == ["light.name_1"]
assert [key for key in registry.entities] == ["light.name_1"]
async def test_turn_on_light(hass: core.HomeAssistant):