evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use a dictcomp to reconstruct DeviceInfo in the device_registry (#117286)

Browse source 
Use a dictcomp to reconstruct DeviceInfo

a dictcomp is faster than many sets on the dict by at least
25%

We call this for nearly every device in the registry at
startup
This commit is contained in:
J. Nick Koston 2024-05-12 15:07:12 +09:00 • committed by GitHub
parent 0acf392a50
commit eac4aaef10
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

10
homeassistant/helpers/device_registry.py
View file

@ -683,7 +683,8 @@ class DeviceRegistry(BaseRegistry[dict[str, list[dict[str, Any]]]]):
# Reconstruct a DeviceInfo dict from the arguments. # Reconstruct a DeviceInfo dict from the arguments.
# When we upgrade to Python 3.12, we can change this method to instead # When we upgrade to Python 3.12, we can change this method to instead
# accept kwargs typed as a DeviceInfo dict (PEP 692) # accept kwargs typed as a DeviceInfo dict (PEP 692)
device_info: DeviceInfo = {} device_info: DeviceInfo = { # type: ignore[assignment]
key: val
for key, val in ( for key, val in (
("configuration_url", configuration_url), ("configuration_url", configuration_url),
("connections", connections), ("connections", connections),
@ -700,10 +701,9 @@ class DeviceRegistry(BaseRegistry[dict[str, list[dict[str, Any]]]]):
("suggested_area", suggested_area), ("suggested_area", suggested_area),
("sw_version", sw_version), ("sw_version", sw_version),
("via_device", via_device), ("via_device", via_device),
): )
if val is UNDEFINED: if val is not UNDEFINED
continue }
device_info[key] = val # type: ignore[literal-required]
device_info_type = _validate_device_info(config_entry, device_info) device_info_type = _validate_device_info(config_entry, device_info)