evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address FireServiceRota late code review (#43741)

Browse source 
* Address review comment from PR #38206

* Address review comment from PR #43638

* Address review comment from PR #43700

* isort fixed

* Better code for duty entity update

* Removed all pylint relative-beyond-top-level

* Removed logger entry from entity state method
This commit is contained in:
Ron Klinkien 2020-11-29 23:54:27 +01:00 • committed by GitHub
parent 6eeb9c0e49
commit eab6a0508b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 30 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/fireservicerota/binary_sensor.py
View file

@ -63,7 +63,6 @@ class ResponseBinarySensor(CoordinatorEntity, BinarySensorEntity):
self._state = self._client.on_duty
_LOGGER.debug("Set state of entity 'Duty Binary Sensor' to '%s'", self._state)
return self._state
@property
@ -89,5 +88,4 @@ class ResponseBinarySensor(CoordinatorEntity, BinarySensorEntity):
if key in data
}
_LOGGER.debug("Set attributes of entity 'Duty Binary Sensor' to '%s'", attr)
return attr