From e5383209013bef56d11574ac4b5c8b56c464f3f0 Mon Sep 17 00:00:00 2001 From: Mattias Welponer Date: Mon, 11 Feb 2019 10:20:00 +0100 Subject: [PATCH] HomematicIP fix cover direction (#20901) * Fix cover direction * Update for better readability * Fix lint --- homeassistant/components/homematicip_cloud/cover.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/homematicip_cloud/cover.py b/homeassistant/components/homematicip_cloud/cover.py index 27f26805e81..80fc8f7b430 100644 --- a/homeassistant/components/homematicip_cloud/cover.py +++ b/homeassistant/components/homematicip_cloud/cover.py @@ -15,6 +15,9 @@ DEPENDENCIES = ['homematicip_cloud'] _LOGGER = logging.getLogger(__name__) +HMIP_COVER_OPEN = 0 +HMIP_COVER_CLOSED = 1 + async def async_setup_platform( hass, config, async_add_entities, discovery_info=None): @@ -47,23 +50,24 @@ class HomematicipCoverShutter(HomematicipGenericDevice, CoverDevice): async def async_set_cover_position(self, **kwargs): """Move the cover to a specific position.""" position = kwargs[ATTR_POSITION] - level = position / 100.0 + # HmIP cover is closed:1 -> open:0 + level = 1 - position / 100.0 await self._device.set_shutter_level(level) @property def is_closed(self): """Return if the cover is closed.""" if self._device.shutterLevel is not None: - return self._device.shutterLevel == 0 + return self._device.shutterLevel == HMIP_COVER_CLOSED return None async def async_open_cover(self, **kwargs): """Open the cover.""" - await self._device.set_shutter_level(1) + await self._device.set_shutter_level(HMIP_COVER_OPEN) async def async_close_cover(self, **kwargs): """Close the cover.""" - await self._device.set_shutter_level(0) + await self._device.set_shutter_level(HMIP_COVER_CLOSED) async def async_stop_cover(self, **kwargs): """Stop the device if in motion."""