evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use 0/1 for raspberry pi cover GPIO writes rather than true/false (#13610)

Browse source 
* Use 0/1 for GPIO writes rather than true/false

GPIO pins don't appear to respond to true/false writes, and this is reflected in code elsewhere. For example, in `\components\switch\rpio_gpio.py` the following code is used:

```
    def turn_on(self, **kwargs):
        """Turn the device on."""
        rpi_gpio.write_output(self._port, 0 if self._invert_logic else 1)
        self._state = True
        self.schedule_update_ha_state()
```

This code works. Hence this PR uses 0/1 in the raspberry pi GPIO cover, instead of true/false.

* Update rpi_gpio.py
This commit is contained in:
Chris Jones 2018-04-02 01:37:03 +10:00 • committed by Paulus Schoutsen
parent c8f2810fac
commit dee47d50ec
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
homeassistant/components/cover/rpi_gpio.py
View file

@ -87,7 +87,7 @@ class RPiGPIOCover(CoverDevice):
self._invert_relay = invert_relay self._invert_relay = invert_relay
rpi_gpio.setup_output(self._relay_pin) rpi_gpio.setup_output(self._relay_pin)
rpi_gpio.setup_input(self._state_pin, self._state_pull_mode) rpi_gpio.setup_input(self._state_pin, self._state_pull_mode)
rpi_gpio.write_output(self._relay_pin, not self._invert_relay) rpi_gpio.write_output(self._relay_pin, 0 if self._invert_relay else 1)
@property @property
def name(self): def name(self):
@ -105,9 +105,9 @@ class RPiGPIOCover(CoverDevice):
def _trigger(self): def _trigger(self):
"""Trigger the cover.""" """Trigger the cover."""
rpi_gpio.write_output(self._relay_pin, self._invert_relay) rpi_gpio.write_output(self._relay_pin, 1 if self._invert_relay else 0)
sleep(self._relay_time) sleep(self._relay_time)
rpi_gpio.write_output(self._relay_pin, not self._invert_relay) rpi_gpio.write_output(self._relay_pin, 0 if self._invert_relay else 1)
def close_cover(self, **kwargs): def close_cover(self, **kwargs):
"""Close the cover.""" """Close the cover."""