Fix error for when column does not exist in query to SQL (#91166)

Co-authored-by: J. Nick Koston <nick@koston.org>
This commit is contained in:
dougiteixeira 2023-04-15 19:54:56 -03:00 committed by GitHub
parent 323d16cc21
commit dc03a5c81e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 132 additions and 6 deletions

View file

@ -13,6 +13,8 @@ from homeassistant.data_entry_flow import FlowResultType
from . import (
ENTRY_CONFIG,
ENTRY_CONFIG_INVALID_COLUMN_NAME,
ENTRY_CONFIG_INVALID_COLUMN_NAME_OPT,
ENTRY_CONFIG_INVALID_QUERY,
ENTRY_CONFIG_INVALID_QUERY_OPT,
ENTRY_CONFIG_NO_RESULTS,
@ -120,6 +122,43 @@ async def test_flow_fails_invalid_query(
}
async def test_flow_fails_invalid_column_name(
recorder_mock: Recorder, hass: HomeAssistant
) -> None:
"""Test config flow fails invalid column name."""
result4 = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": config_entries.SOURCE_USER}
)
assert result4["type"] == FlowResultType.FORM
assert result4["step_id"] == "user"
result5 = await hass.config_entries.flow.async_configure(
result4["flow_id"],
user_input=ENTRY_CONFIG_INVALID_COLUMN_NAME,
)
assert result5["type"] == FlowResultType.FORM
assert result5["errors"] == {
"column": "column_invalid",
}
result5 = await hass.config_entries.flow.async_configure(
result4["flow_id"],
user_input=ENTRY_CONFIG,
)
assert result5["type"] == FlowResultType.CREATE_ENTRY
assert result5["title"] == "Get Value"
assert result5["options"] == {
"name": "Get Value",
"query": "SELECT 5 as value",
"column": "value",
"unit_of_measurement": "MiB",
"value_template": None,
}
async def test_options_flow(recorder_mock: Recorder, hass: HomeAssistant) -> None:
"""Test options config flow."""
entry = MockConfigEntry(
@ -318,6 +357,60 @@ async def test_options_flow_fails_invalid_query(
}
async def test_options_flow_fails_invalid_column_name(
recorder_mock: Recorder, hass: HomeAssistant
) -> None:
"""Test options flow fails invalid column name."""
entry = MockConfigEntry(
domain=DOMAIN,
data={},
options={
"name": "Get Value",
"query": "SELECT 5 as value",
"column": "value",
"unit_of_measurement": "MiB",
"value_template": None,
},
)
entry.add_to_hass(hass)
with patch(
"homeassistant.components.sql.async_setup_entry",
return_value=True,
):
assert await hass.config_entries.async_setup(entry.entry_id)
await hass.async_block_till_done()
result = await hass.config_entries.options.async_init(entry.entry_id)
result2 = await hass.config_entries.options.async_configure(
result["flow_id"],
user_input=ENTRY_CONFIG_INVALID_COLUMN_NAME_OPT,
)
assert result2["type"] == FlowResultType.FORM
assert result2["errors"] == {
"column": "column_invalid",
}
result4 = await hass.config_entries.options.async_configure(
result["flow_id"],
user_input={
"query": "SELECT 5 as value",
"column": "value",
"unit_of_measurement": "MiB",
},
)
assert result4["type"] == FlowResultType.CREATE_ENTRY
assert result4["data"] == {
"name": "Get Value",
"query": "SELECT 5 as value",
"column": "value",
"unit_of_measurement": "MiB",
}
async def test_options_flow_db_url_empty(
recorder_mock: Recorder, hass: HomeAssistant
) -> None: