From dbb2c64d862387e19723f37c4900ede3ea940c18 Mon Sep 17 00:00:00 2001 From: dewdrop <81049573+dewdropawoo@users.noreply.github.com> Date: Sun, 20 Feb 2022 06:33:19 -0800 Subject: [PATCH] Fix broken aftership sensor after pyaftership 21.11.0 bump (#66855) * Fix update to pyaftership 21.11.0 Variable name collision and a missing property access was causing this sensor to always return zero elements. * Move subscripting out of awaited statement --- homeassistant/components/aftership/sensor.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/aftership/sensor.py b/homeassistant/components/aftership/sensor.py index 82b844bbd01..62d138d2123 100644 --- a/homeassistant/components/aftership/sensor.py +++ b/homeassistant/components/aftership/sensor.py @@ -149,10 +149,10 @@ class AfterShipSensor(SensorEntity): status_to_ignore = {"delivered"} status_counts: dict[str, int] = {} - trackings = [] + parsed_trackings = [] not_delivered_count = 0 - for track in trackings: + for track in trackings["trackings"]: status = track["tag"].lower() name = ( track["tracking_number"] if track["title"] is None else track["title"] @@ -163,7 +163,7 @@ class AfterShipSensor(SensorEntity): else track["checkpoints"][-1] ) status_counts[status] = status_counts.get(status, 0) + 1 - trackings.append( + parsed_trackings.append( { "name": name, "tracking_number": track["tracking_number"], @@ -183,7 +183,7 @@ class AfterShipSensor(SensorEntity): self._attributes = { **status_counts, - ATTR_TRACKINGS: trackings, + ATTR_TRACKINGS: parsed_trackings, } self._state = not_delivered_count