evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Config and service validation for shell_command component.

Browse source
This commit is contained in:
Jan Harkes 2016-04-12 00:52:39 -04:00
parent 1deaf2fe8f
commit d90f31bf6e
2 changed files with 28 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tests/components/test_shell_command.py
View file

@ -5,6 +5,7 @@ import unittest
from unittest.mock import patch
from subprocess import SubprocessError
from homeassistant.bootstrap import _setup_component
from homeassistant.components import shell_command
from tests.common import get_test_home_assistant
@ -25,11 +26,11 @@ class TestShellCommand(unittest.TestCase):
"""Test if able to call a configured service."""
with tempfile.TemporaryDirectory() as tempdirname:
path = os.path.join(tempdirname, 'called.txt')
self.assertTrue(shell_command.setup(self.hass, {
'shell_command': {
assert _setup_component(self.hass, shell_command.DOMAIN, {
shell_command.DOMAIN: {
'test_service': "date > {}".format(path)
}
}))
})
self.hass.services.call('shell_command', 'test_service',
blocking=True)
@ -38,16 +39,17 @@ class TestShellCommand(unittest.TestCase):
def test_config_not_dict(self):
"""Test if config is not a dict."""
self.assertFalse(shell_command.setup(self.hass, {
'shell_command': ['some', 'weird', 'list']
}))
assert not _setup_component(self.hass, shell_command.DOMAIN, {
shell_command.DOMAIN: ['some', 'weird', 'list']
})
def test_config_not_valid_service_names(self):
"""Test if config contains invalid service names."""
self.assertFalse(shell_command.setup(self.hass, {
'shell_command': {
assert not _setup_component(self.hass, shell_command.DOMAIN, {
shell_command.DOMAIN: {
'this is invalid because space': 'touch bla.txt'
}}))
}
})
@patch('homeassistant.components.shell_command.subprocess.call',
side_effect=SubprocessError)
@ -56,11 +58,11 @@ class TestShellCommand(unittest.TestCase):
"""Test subprocess."""
with tempfile.TemporaryDirectory() as tempdirname:
path = os.path.join(tempdirname, 'called.txt')
self.assertTrue(shell_command.setup(self.hass, {
'shell_command': {
assert _setup_component(self.hass, shell_command.DOMAIN, {
shell_command.DOMAIN: {
'test_service': "touch {}".format(path)
}
}))
})
self.hass.services.call('shell_command', 'test_service',
blocking=True)