evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix update of uncategorized OurGroceries items (#105255)

Browse source 
* Fix update of uncategorized OurGroceries items

* Address code review comments
This commit is contained in:
On Freund 2023-12-07 23:11:08 +02:00 • committed by Franck Nijhof
parent 4953a36da8
commit d89f6b5eb0
No known key found for this signature in database
GPG key ID: D62583BA8AB11CA3
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/ourgroceries/todo.py
View file

@ -89,7 +89,7 @@ class OurGroceriesTodoListEntity(
if item.summary: if item.summary:
api_items = self.coordinator.data[self._list_id]["list"]["items"] api_items = self.coordinator.data[self._list_id]["list"]["items"]
category = next( category = next(
api_item["categoryId"] api_item.get("categoryId")
for api_item in api_items for api_item in api_items
if api_item["id"] == item.uid if api_item["id"] == item.uid
) )

12
tests/components/ourgroceries/test_todo.py
View file

@ -142,12 +142,20 @@ async def test_update_todo_item_status(
@pytest.mark.parametrize( @pytest.mark.parametrize(
("items"), [[{"id": "12345", "name": "Soda", "categoryId": "test_category"}]] ("items", "category"),
[
(
[{"id": "12345", "name": "Soda", "categoryId": "test_category"}],
"test_category",
),
([{"id": "12345", "name": "Uncategorized"}], None),
],
) )
async def test_update_todo_item_summary( async def test_update_todo_item_summary(
hass: HomeAssistant, hass: HomeAssistant,
setup_integration: None, setup_integration: None,
ourgroceries: AsyncMock, ourgroceries: AsyncMock,
category: str | None,
) -> None: ) -> None:
"""Test for updating an item summary.""" """Test for updating an item summary."""
@ -171,7 +179,7 @@ async def test_update_todo_item_summary(
) )
assert ourgroceries.change_item_on_list assert ourgroceries.change_item_on_list
args = ourgroceries.change_item_on_list.call_args args = ourgroceries.change_item_on_list.call_args
assert args.args == ("test_list", "12345", "test_category", "Milk") assert args.args == ("test_list", "12345", category, "Milk")
@pytest.mark.parametrize( @pytest.mark.parametrize(