evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve error message for sensors with a non-numeric value (#93399)

Browse source 
* Improve error message for sensors with a non-numeric value

* Address review comment
This commit is contained in:
Erik Montnemery 2023-05-23 15:54:24 +02:00 • committed by GitHub
parent f8f83906f8
commit d62cdf3d65
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
homeassistant/components/sensor/__init__.py
View file

@ -583,11 +583,11 @@ class SensorEntity(Entity):
numerical_value = float(value) # type:ignore[arg-type] numerical_value = float(value) # type:ignore[arg-type]
except (TypeError, ValueError) as err: except (TypeError, ValueError) as err:
raise ValueError( raise ValueError(
f"Sensor {self.entity_id} has device class {device_class}, " f"Sensor {self.entity_id} has device class '{device_class}', "
f"state class {state_class} unit {unit_of_measurement} and " f"state class '{state_class}' unit '{unit_of_measurement}' and "
f"suggested precision {suggested_precision} thus indicating it " f"suggested precision '{suggested_precision}' thus indicating it "
f"has a numeric value; however, it has the non-numeric value: " f"has a numeric value; however, it has the non-numeric value: "
f"{value} ({type(value)})" f"'{value}' ({type(value)})"
) from err ) from err
else: else:
numerical_value = value numerical_value = value

2
tests/components/sensor/test_init.py
View file

@ -1842,7 +1842,7 @@ async def test_non_numeric_validation_error(
assert ( assert (
"thus indicating it has a numeric value; " "thus indicating it has a numeric value; "
f"however, it has the non-numeric value: {native_value}" f"however, it has the non-numeric value: '{native_value}'"
) in caplog.text ) in caplog.text