evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Environment Canada config_flow fix (#59029)

Browse source
This commit is contained in:
Glenn Waters 2021-11-04 23:11:22 -04:00 • committed by GitHub
parent e57c60bb2f
commit ca00551e4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
homeassistant/components/environment_canada/config_flow.py
View file

@ -20,13 +20,12 @@ async def validate_input(data):
lat = data.get(CONF_LATITUDE) lat = data.get(CONF_LATITUDE)
lon = data.get(CONF_LONGITUDE) lon = data.get(CONF_LONGITUDE)
station = data.get(CONF_STATION) station = data.get(CONF_STATION)
lang = data.get(CONF_LANGUAGE) lang = data.get(CONF_LANGUAGE).lower()
weather_data = ECWeather( if station:
station_id=station, weather_data = ECWeather(station_id=station, language=lang)
coordinates=(lat, lon), else:
language=lang.lower(), weather_data = ECWeather(coordinates=(lat, lon), language=lang)
)
await weather_data.update() await weather_data.update()
if lat is None or lon is None: if lat is None or lon is None:

20
tests/components/environment_canada/test_config_flow.py
View file

@ -123,7 +123,24 @@ async def test_exception_handling(hass, error):
assert result["errors"] == {"base": base_error} assert result["errors"] == {"base": base_error}
async def test_lat_or_lon_not_specified(hass): async def test_import_station_not_specified(hass):
"""Test that the import step works."""
with mocked_ec(), patch(
"homeassistant.components.environment_canada.async_setup_entry",
return_value=True,
):
fake_config = dict(FAKE_CONFIG)
del fake_config[CONF_STATION]
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_IMPORT}, data=fake_config
)
await hass.async_block_till_done()
assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
assert result["data"] == FAKE_CONFIG
assert result["title"] == FAKE_TITLE
async def test_import_lat_lon_not_specified(hass):
"""Test that the import step works.""" """Test that the import step works."""
with mocked_ec(), patch( with mocked_ec(), patch(
"homeassistant.components.environment_canada.async_setup_entry", "homeassistant.components.environment_canada.async_setup_entry",
@ -131,6 +148,7 @@ async def test_lat_or_lon_not_specified(hass):
): ):
fake_config = dict(FAKE_CONFIG) fake_config = dict(FAKE_CONFIG)
del fake_config[CONF_LATITUDE] del fake_config[CONF_LATITUDE]
del fake_config[CONF_LONGITUDE]
result = await hass.config_entries.flow.async_init( result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_IMPORT}, data=fake_config DOMAIN, context={"source": SOURCE_IMPORT}, data=fake_config
) )