evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reduce duplicate code in baf for entities with descriptions (#119945)

Browse source 
* Reduce duplicate code in baf for entities with descriptions

* Reduce duplicate code in baf for entities with descriptions

* no cover

* no cover
This commit is contained in:
J. Nick Koston 2024-06-18 20:39:32 -05:00 • committed by GitHub
parent ef51fc0d97
commit c686eda305
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 25 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

21
homeassistant/components/baf/binary_sensor.py
View file

@ -17,7 +17,7 @@ from homeassistant.core import HomeAssistant, callback
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from . import BAFConfigEntry
from .entity import BAFEntity
from .entity import BAFDescriptionEntity
@dataclass(frozen=True, kw_only=True)
@ -45,27 +45,18 @@ async def async_setup_entry(
) -> None:
"""Set up BAF binary sensors."""
device = entry.runtime_data
sensors_descriptions: list[BAFBinarySensorDescription] = []
if device.has_occupancy:
sensors_descriptions.extend(OCCUPANCY_SENSORS)
async_add_entities(
BAFBinarySensor(device, description) for description in sensors_descriptions
)
async_add_entities(
BAFBinarySensor(device, description) for description in OCCUPANCY_SENSORS
)
class BAFBinarySensor(BAFEntity, BinarySensorEntity):
class BAFBinarySensor(BAFDescriptionEntity, BinarySensorEntity):
"""BAF binary sensor."""
entity_description: BAFBinarySensorDescription
def __init__(self, device: Device, description: BAFBinarySensorDescription) -> None:
"""Initialize the entity."""
self.entity_description = description
super().__init__(device)
self._attr_unique_id = f"{self._device.mac_address}-{description.key}"
@callback
def _async_update_attrs(self) -> None:
"""Update attrs from device."""
description = self.entity_description
self._attr_is_on = description.value_fn(self._device)
self._attr_is_on = self.entity_description.value_fn(self._device)