evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move to async for aladdin connect integration (#73954)

Browse source 
* Moved to AIOAladdinConnect API

* Added callback logic for door status

* close unused connections

* Close connection after verification

* Matched to current version

* Matched __init__.py to current release

* Matched cover.py to existing version

* added missing awaits

* Moved callback

* Bumped AIOAladdinConnect to 0.1.3

* Removed await from callback config

* Finished tests

* Added callback test

* Bumped AIOAladdinConnect to 0.1.4

* Finished tests

* Callback correct call to update HA

* Modified calls to state machine

* Modified update path

* Removed unused status

* Bumped AIOAladdinConnect to 0.1.7

* Revised test_cover cover tests and bumped AIOAladdinConnect to 0.1.10

* Bumped AIOAladdinConnect to 0.1.11

* Bumped AIOAladdinConenct to 0.1.12

* Bumped AIOAladdinConnect to 0.1.13

* Bumped AIOAladdinConnect to 0.1.14

* Added ability to handle multiple doors

* Added timout errors to config flow

* asyncio timout error added to setup retry

* Cleanup added to hass proceedure

* Bumped AIOAladdinConnect to 0.1.16

* Bumped AIOAladdinConnect to 0.1.18

* Bumped AIOAladdinConnect to 0.1.19

* Bumped AIOAladdinConnect to 0.1.20

* Addressed recommended changes: SCAN_INTERVAL and spelling

* Moved to async_get_clientsession and bumped AIOAladdinConnect to 0.1.21

* Missing test for new code structure

* removed extra call to write_ha_state, callback decorator, cleaned up tests

* Update tests/components/aladdin_connect/test_init.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Removed extra_attributes.

* Added typing to variable acc

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
This commit is contained in:
mkmer 2022-06-28 17:22:18 -04:00 • committed by GitHub
parent 7d74301045
commit c3a2fce5cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 458 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

113
tests/components/aladdin_connect/test_init.py
View file

@ -1,35 +1,77 @@
"""Test for Aladdin Connect init logic."""
from unittest.mock import patch
from unittest.mock import MagicMock, patch
from aiohttp import ClientConnectionError
from homeassistant.components.aladdin_connect.const import DOMAIN
from homeassistant.config_entries import ConfigEntryState
from homeassistant.core import HomeAssistant
from tests.common import MockConfigEntry
from tests.common import AsyncMock, MockConfigEntry
YAML_CONFIG = {"username": "test-user", "password": "test-password"}
async def test_entry_password_fail(hass: HomeAssistant):
"""Test password fail during entry."""
entry = MockConfigEntry(
async def test_setup_get_doors_errors(hass: HomeAssistant) -> None:
"""Test component setup Get Doors Errors."""
config_entry = MockConfigEntry(
domain=DOMAIN,
data={"username": "test-user", "password": "test-password"},
data=YAML_CONFIG,
unique_id="test-id",
)
entry.add_to_hass(hass)
config_entry.add_to_hass(hass)
with patch(
"homeassistant.components.aladdin_connect.cover.AladdinConnectClient.login",
return_value=False,
return_value=True,
), patch(
"homeassistant.components.aladdin_connect.cover.AladdinConnectClient.get_doors",
return_value=None,
):
assert await hass.config_entries.async_setup(config_entry.entry_id) is True
await hass.async_block_till_done()
assert len(hass.states.async_all()) == 0
async def test_setup_login_error(
hass: HomeAssistant, mock_aladdinconnect_api: MagicMock
) -> None:
"""Test component setup Login Errors."""
config_entry = MockConfigEntry(
domain=DOMAIN,
data=YAML_CONFIG,
unique_id="test-id",
)
config_entry.add_to_hass(hass)
mock_aladdinconnect_api.login.return_value = False
with patch(
"homeassistant.components.aladdin_connect.cover.AladdinConnectClient",
return_value=mock_aladdinconnect_api,
):
await hass.config_entries.async_setup(entry.entry_id)
await hass.async_block_till_done()
assert entry.state is ConfigEntryState.SETUP_ERROR
assert await hass.config_entries.async_setup(config_entry.entry_id) is False
async def test_load_and_unload(hass: HomeAssistant) -> None:
"""Test loading and unloading Aladdin Connect entry."""
async def test_setup_connection_error(
hass: HomeAssistant, mock_aladdinconnect_api: MagicMock
) -> None:
"""Test component setup Login Errors."""
config_entry = MockConfigEntry(
domain=DOMAIN,
data=YAML_CONFIG,
unique_id="test-id",
)
config_entry.add_to_hass(hass)
mock_aladdinconnect_api.login.side_effect = ClientConnectionError
with patch(
"homeassistant.components.aladdin_connect.AladdinConnectClient",
return_value=mock_aladdinconnect_api,
):
assert await hass.config_entries.async_setup(config_entry.entry_id) is False
async def test_setup_component_no_error(hass: HomeAssistant) -> None:
"""Test component setup No Error."""
config_entry = MockConfigEntry(
domain=DOMAIN,
data=YAML_CONFIG,
@ -41,6 +83,49 @@ async def test_load_and_unload(hass: HomeAssistant) -> None:
return_value=True,
):
assert await hass.config_entries.async_setup(config_entry.entry_id)
await hass.async_block_till_done()
assert config_entry.state == ConfigEntryState.LOADED
assert len(hass.config_entries.async_entries(DOMAIN)) == 1
async def test_entry_password_fail(
hass: HomeAssistant, mock_aladdinconnect_api: MagicMock
):
"""Test password fail during entry."""
entry = MockConfigEntry(
domain=DOMAIN,
data={"username": "test-user", "password": "test-password"},
)
entry.add_to_hass(hass)
mock_aladdinconnect_api.login = AsyncMock(return_value=False)
with patch(
"homeassistant.components.aladdin_connect.AladdinConnectClient",
return_value=mock_aladdinconnect_api,
):
await hass.config_entries.async_setup(entry.entry_id)
await hass.async_block_till_done()
assert entry.state is ConfigEntryState.SETUP_ERROR
async def test_load_and_unload(
hass: HomeAssistant, mock_aladdinconnect_api: MagicMock
) -> None:
"""Test loading and unloading Aladdin Connect entry."""
config_entry = MockConfigEntry(
domain=DOMAIN,
data=YAML_CONFIG,
unique_id="test-id",
)
config_entry.add_to_hass(hass)
with patch(
"homeassistant.components.aladdin_connect.AladdinConnectClient",
return_value=mock_aladdinconnect_api,
):
await hass.config_entries.async_setup(config_entry.entry_id)
await hass.async_block_till_done()