evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tweak mFi switch behavior to avoid false states

Browse source 
When we update the mFi server for the state of a switch, the new
state is not always reported immediately if we update right after
the action (the server is not RESTful).

This patch adds some internal target-state handling to report the
desired state on the next poll, allowing any subsequent polls to
override that state.

Also, bump the version requirement for mficlient to 0.2.2 to absorb
a bug fix.
This commit is contained in:
Dan Smith 2016-02-07 19:28:23 +00:00
parent d49fae86e4
commit c113997609
3 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/sensor/mfi.py
View file

@ -14,7 +14,7 @@ from homeassistant.components.sensor import DOMAIN
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
from homeassistant.helpers import validate_config from homeassistant.helpers import validate_config
REQUIREMENTS = ['mficlient==0.2'] REQUIREMENTS = ['mficlient==0.2.2']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)

10
homeassistant/components/switch/mfi.py
View file

@ -12,7 +12,7 @@ from homeassistant.components.switch import DOMAIN, SwitchDevice
from homeassistant.const import CONF_USERNAME, CONF_PASSWORD from homeassistant.const import CONF_USERNAME, CONF_PASSWORD
from homeassistant.helpers import validate_config from homeassistant.helpers import validate_config
REQUIREMENTS = ['mficlient==0.2'] REQUIREMENTS = ['mficlient==0.2.2']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
@ -56,6 +56,7 @@ class MfiSwitch(SwitchDevice):
""" An mFi switch-able device. """ """ An mFi switch-able device. """
def __init__(self, port): def __init__(self, port):
self._port = port self._port = port
self._target_state = None
@property @property
def should_poll(self): def should_poll(self):
@ -75,14 +76,17 @@ class MfiSwitch(SwitchDevice):
def update(self): def update(self):
self._port.refresh() self._port.refresh()
if self._target_state is not None:
self._port.data['output'] = float(self._target_state)
self._target_state = None
def turn_on(self): def turn_on(self):
self._port.control(True) self._port.control(True)
self._port.data['output'] = 1.0 self._target_state = True
def turn_off(self): def turn_off(self):
self._port.control(False) self._port.control(False)
self._port.data['output'] = 0.0 self._target_state = False
@property @property
def current_power_mwh(self): def current_power_mwh(self):

2
requirements_all.txt
View file

@ -107,7 +107,7 @@ limitlessled==1.0.0
# homeassistant.components.sensor.mfi # homeassistant.components.sensor.mfi
# homeassistant.components.switch.mfi # homeassistant.components.switch.mfi
mficlient==0.2 mficlient==0.2.2
# homeassistant.components.discovery # homeassistant.components.discovery
netdisco==0.5.2 netdisco==0.5.2