Fix pyload async_update SensorEntity raising exceptions (#119655)

* Fix Sensorentity raising exceptions

* Increase test coverage
This commit is contained in:
Mr. Bubbles 2024-06-14 20:47:06 +02:00 committed by GitHub
parent 05cbda0e50
commit c077c2a972
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 51 additions and 18 deletions

View file

@ -2,15 +2,19 @@
from unittest.mock import AsyncMock
from freezegun.api import FrozenDateTimeFactory
from pyloadapi.exceptions import CannotConnect, InvalidAuth, ParserError
import pytest
from syrupy.assertion import SnapshotAssertion
from homeassistant.components.pyload.sensor import SCAN_INTERVAL
from homeassistant.components.sensor import DOMAIN
from homeassistant.core import HomeAssistant
from homeassistant.helpers.typing import ConfigType
from homeassistant.setup import async_setup_component
from tests.common import async_fire_time_changed
@pytest.mark.usefixtures("mock_pyloadapi")
async def test_setup(
@ -60,9 +64,9 @@ async def test_setup_exceptions(
@pytest.mark.parametrize(
("exception", "expected_exception"),
[
(CannotConnect, "UpdateFailed"),
(ParserError, "UpdateFailed"),
(InvalidAuth, "UpdateFailed"),
(CannotConnect, "Unable to connect and retrieve data from pyLoad API"),
(ParserError, "Unable to parse data from pyLoad API"),
(InvalidAuth, "Authentication failed, trying to reauthenticate"),
],
)
async def test_sensor_update_exceptions(
@ -80,5 +84,31 @@ async def test_sensor_update_exceptions(
assert await async_setup_component(hass, DOMAIN, pyload_config)
await hass.async_block_till_done()
assert len(hass.states.async_all(DOMAIN)) == 0
assert len(hass.states.async_all(DOMAIN)) == 1
assert expected_exception in caplog.text
async def test_sensor_invalid_auth(
hass: HomeAssistant,
pyload_config: ConfigType,
mock_pyloadapi: AsyncMock,
caplog: pytest.LogCaptureFixture,
freezer: FrozenDateTimeFactory,
) -> None:
"""Test invalid auth during sensor update."""
assert await async_setup_component(hass, DOMAIN, pyload_config)
await hass.async_block_till_done()
assert len(hass.states.async_all(DOMAIN)) == 1
mock_pyloadapi.get_status.side_effect = InvalidAuth
mock_pyloadapi.login.side_effect = InvalidAuth
freezer.tick(SCAN_INTERVAL)
async_fire_time_changed(hass)
await hass.async_block_till_done()
assert (
"Authentication failed for username, check your login credentials"
in caplog.text
)