evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Exclude more media player attributes from recorder (#69209)

Browse source
This commit is contained in:
Franck Nijhof 2022-04-03 20:37:13 +02:00 • committed by GitHub
parent 40fba130e8
commit bd1d7bdbb7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 26 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
homeassistant/components/media_player/__init__.py
View file

@ -70,6 +70,7 @@ from .browse_media import BrowseMedia, async_process_play_media_url # noqa: F40
from .const import ( # noqa: F401 from .const import ( # noqa: F401
ATTR_APP_ID, ATTR_APP_ID,
ATTR_APP_NAME, ATTR_APP_NAME,
ATTR_ENTITY_PICTURE_LOCAL,
ATTR_GROUP_MEMBERS, ATTR_GROUP_MEMBERS,
ATTR_INPUT_SOURCE, ATTR_INPUT_SOURCE,
ATTR_INPUT_SOURCE_LIST, ATTR_INPUT_SOURCE_LIST,
@ -954,7 +955,7 @@ class MediaPlayerEntity(Entity):
state_attr[attr] = value state_attr[attr] = value
if self.media_image_remotely_accessible: if self.media_image_remotely_accessible:
state_attr["entity_picture_local"] = self.media_image_local state_attr[ATTR_ENTITY_PICTURE_LOCAL] = self.media_image_local
return state_attr return state_attr

1
homeassistant/components/media_player/const.py
View file

@ -6,6 +6,7 @@ CONTENT_AUTH_EXPIRY_TIME = 3600 * 24
ATTR_APP_ID = "app_id" ATTR_APP_ID = "app_id"
ATTR_APP_NAME = "app_name" ATTR_APP_NAME = "app_name"
ATTR_ENTITY_PICTURE_LOCAL = "entity_picture_local"
ATTR_GROUP_MEMBERS = "group_members" ATTR_GROUP_MEMBERS = "group_members"
ATTR_INPUT_SOURCE = "source" ATTR_INPUT_SOURCE = "source"
ATTR_INPUT_SOURCE_LIST = "source_list" ATTR_INPUT_SOURCE_LIST = "source_list"

17
homeassistant/components/media_player/recorder.py
View file

@ -4,10 +4,23 @@ from __future__ import annotations
from homeassistant.const import ATTR_ENTITY_PICTURE from homeassistant.const import ATTR_ENTITY_PICTURE
from homeassistant.core import HomeAssistant, callback from homeassistant.core import HomeAssistant, callback
from . import ATTR_INPUT_SOURCE_LIST, ATTR_SOUND_MODE_LIST from . import (
ATTR_ENTITY_PICTURE_LOCAL,
ATTR_INPUT_SOURCE_LIST,
ATTR_MEDIA_POSITION,
ATTR_MEDIA_POSITION_UPDATED_AT,
ATTR_SOUND_MODE_LIST,
)
@callback @callback
def exclude_attributes(hass: HomeAssistant) -> set[str]: def exclude_attributes(hass: HomeAssistant) -> set[str]:
"""Exclude static and token attributes from being recorded in the database.""" """Exclude static and token attributes from being recorded in the database."""
return {ATTR_SOUND_MODE_LIST, ATTR_ENTITY_PICTURE, ATTR_INPUT_SOURCE_LIST} return {
ATTR_ENTITY_PICTURE_LOCAL,
ATTR_ENTITY_PICTURE,
ATTR_INPUT_SOURCE_LIST,
ATTR_MEDIA_POSITION_UPDATED_AT,
ATTR_MEDIA_POSITION,
ATTR_SOUND_MODE_LIST,
}

10
tests/components/media_player/test_recorder.py
View file

@ -5,7 +5,10 @@ from datetime import timedelta
from homeassistant.components import media_player from homeassistant.components import media_player
from homeassistant.components.media_player.const import ( from homeassistant.components.media_player.const import (
ATTR_ENTITY_PICTURE_LOCAL,
ATTR_INPUT_SOURCE_LIST, ATTR_INPUT_SOURCE_LIST,
ATTR_MEDIA_POSITION,
ATTR_MEDIA_POSITION_UPDATED_AT,
ATTR_SOUND_MODE_LIST, ATTR_SOUND_MODE_LIST,
) )
from homeassistant.components.recorder.models import StateAttributes, States from homeassistant.components.recorder.models import StateAttributes, States
@ -42,7 +45,10 @@ async def test_exclude_attributes(hass):
states: list[State] = await hass.async_add_executor_job(_fetch_states) states: list[State] = await hass.async_add_executor_job(_fetch_states)
assert len(states) > 1 assert len(states) > 1
for state in states: for state in states:
assert ATTR_SOUND_MODE_LIST not in state.attributes
assert ATTR_ENTITY_PICTURE not in state.attributes assert ATTR_ENTITY_PICTURE not in state.attributes
assert ATTR_INPUT_SOURCE_LIST not in state.attributes assert ATTR_ENTITY_PICTURE_LOCAL not in state.attributes
assert ATTR_FRIENDLY_NAME in state.attributes assert ATTR_FRIENDLY_NAME in state.attributes
assert ATTR_INPUT_SOURCE_LIST not in state.attributes
assert ATTR_MEDIA_POSITION not in state.attributes
assert ATTR_MEDIA_POSITION_UPDATED_AT not in state.attributes
assert ATTR_SOUND_MODE_LIST not in state.attributes