evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cancel timer on enphase_envoy config entry unload (#111406)

Browse source 
* lingeringtimer

* Add async_cleanup to enphase_envoy_coordinator and call from unload_entry
This commit is contained in:
Arie Catsman 2024-04-24 16:33:14 +02:00 • committed by GitHub
parent c9ff618ef0
commit bbaa0c16cc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/enphase_envoy/__init__.py
View file

@ -46,6 +46,8 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
"""Unload a config entry.""" """Unload a config entry."""
coordinator = hass.data[DOMAIN][entry.entry_id]
await coordinator.async_cleanup()
unload_ok = await hass.config_entries.async_unload_platforms(entry, PLATFORMS) unload_ok = await hass.config_entries.async_unload_platforms(entry, PLATFORMS)
if unload_ok: if unload_ok:
hass.data[DOMAIN].pop(entry.entry_id) hass.data[DOMAIN].pop(entry.entry_id)

6
homeassistant/components/enphase_envoy/coordinator.py
View file

@ -159,3 +159,9 @@ class EnphaseUpdateCoordinator(DataUpdateCoordinator[dict[str, Any]]):
return envoy_data.raw return envoy_data.raw
raise RuntimeError("Unreachable code in _async_update_data") # pragma: no cover raise RuntimeError("Unreachable code in _async_update_data") # pragma: no cover
async def async_cleanup(self) -> None:
"""Cleanup coordinator."""
if self._cancel_token_refresh:
self._cancel_token_refresh()
self._cancel_token_refresh = None

2
tests/components/enphase_envoy/conftest.py
View file

@ -343,7 +343,7 @@ def mock_envoy_fixture(
@pytest.fixture(name="setup_enphase_envoy") @pytest.fixture(name="setup_enphase_envoy")
async def setup_enphase_envoy_fixture(hass, config, mock_envoy): async def setup_enphase_envoy_fixture(hass: HomeAssistant, config, mock_envoy):
"""Define a fixture to set up Enphase Envoy.""" """Define a fixture to set up Enphase Envoy."""
with ( with (
patch( patch(