evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add dimmable lights support to niko home control (#90141)

Browse source 
* added support for dimmable lights and auto host discover

* split up merge request

* fixed feedback brightness support

* fixed feedback

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>

* resolved feedback

---------

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
This commit is contained in:
jellenijhof12 2023-03-30 08:59:29 +02:00 • committed by GitHub
parent 053ed3cfdc
commit ba32e28fc6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

47
homeassistant/components/niko_home_control/light.py
View file

@ -8,8 +8,13 @@ from typing import Any
import nikohomecontrol import nikohomecontrol
import voluptuous as vol import voluptuous as vol
# Import the device class from the component that you want to support from homeassistant.components.light import (
from homeassistant.components.light import PLATFORM_SCHEMA, ColorMode, LightEntity ATTR_BRIGHTNESS,
PLATFORM_SCHEMA,
ColorMode,
LightEntity,
brightness_supported,
)
from homeassistant.const import CONF_HOST from homeassistant.const import CONF_HOST
from homeassistant.core import HomeAssistant from homeassistant.core import HomeAssistant
from homeassistant.exceptions import PlatformNotReady from homeassistant.exceptions import PlatformNotReady
@ -52,36 +57,23 @@ async def async_setup_platform(
class NikoHomeControlLight(LightEntity): class NikoHomeControlLight(LightEntity):
"""Representation of an Niko Light.""" """Representation of an Niko Light."""
_attr_color_mode = ColorMode.ONOFF
_attr_supported_color_modes = {ColorMode.ONOFF}
def __init__(self, light, data): def __init__(self, light, data):
"""Set up the Niko Home Control light platform.""" """Set up the Niko Home Control light platform."""
self._data = data self._data = data
self._light = light self._light = light
self._unique_id = f"light-{light.id}" self._attr_unique_id = f"light-{light.id}"
self._name = light.name self._attr_name = light.name
self._state = light.is_on self._attr_is_on = light.is_on
self._attr_color_mode = ColorMode.ONOFF
@property self._attr_supported_color_modes = {ColorMode.ONOFF}
def unique_id(self): if light._state["type"] == 2:
"""Return unique ID for light.""" self._attr_color_mode = ColorMode.BRIGHTNESS
return self._unique_id self._attr_supported_color_modes = {ColorMode.BRIGHTNESS}
@property
def name(self):
"""Return the display name of this light."""
return self._name
@property
def is_on(self):
"""Return true if light is on."""
return self._state
def turn_on(self, **kwargs: Any) -> None: def turn_on(self, **kwargs: Any) -> None:
"""Instruct the light to turn on.""" """Instruct the light to turn on."""
_LOGGER.debug("Turn on: %s", self.name) _LOGGER.debug("Turn on: %s", self.name)
self._light.turn_on() self._light.turn_on(kwargs.get(ATTR_BRIGHTNESS, 255) / 2.55)
def turn_off(self, **kwargs: Any) -> None: def turn_off(self, **kwargs: Any) -> None:
"""Instruct the light to turn off.""" """Instruct the light to turn off."""
@ -91,7 +83,10 @@ class NikoHomeControlLight(LightEntity):
async def async_update(self) -> None: async def async_update(self) -> None:
"""Get the latest data from NikoHomeControl API.""" """Get the latest data from NikoHomeControl API."""
await self._data.async_update() await self._data.async_update()
self._state = self._data.get_state(self._light.id) state = self._data.get_state(self._light.id)
self._attr_is_on = state != 0
if brightness_supported(self.supported_color_modes):
self._attr_brightness = state * 2.55
class NikoHomeControlData: class NikoHomeControlData:
@ -122,5 +117,5 @@ class NikoHomeControlData:
"""Find and filter state based on action id.""" """Find and filter state based on action id."""
for state in self.data: for state in self.data:
if state["id"] == aid: if state["id"] == aid:
return state["value1"] != 0 return state["value1"]
_LOGGER.error("Failed to retrieve state off unknown light") _LOGGER.error("Failed to retrieve state off unknown light")