evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update control4 to use CoordinatorEntity (#39466)

Browse source
This commit is contained in:
J. Nick Koston 2020-08-30 13:27:46 -05:00 • committed by GitHub
parent ab0b0dc51c
commit b57f33c41a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
homeassistant/components/control4/__init__.py
View file

@ -18,8 +18,11 @@ from homeassistant.const import (
)
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import ConfigEntryNotReady
from homeassistant.helpers import aiohttp_client, device_registry as dr, entity
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator
from homeassistant.helpers import aiohttp_client, device_registry as dr
from homeassistant.helpers.update_coordinator import (
CoordinatorEntity,
DataUpdateCoordinator,
)
from .const import (
CONF_ACCOUNT,
@ -154,7 +157,7 @@ async def get_items_of_category(hass: HomeAssistant, entry: ConfigEntry, categor
return return_list
class Control4Entity(entity.Entity):
class Control4Entity(CoordinatorEntity):
"""Base entity for Control4."""
def __init__(
@ -170,11 +173,11 @@ class Control4Entity(entity.Entity):
device_id: int,
):
"""Initialize a Control4 entity."""
super().__init__(coordinator)
self.entry = entry
self.entry_data = entry_data
self._name = name
self._idx = idx
self._coordinator = coordinator
self._controller_unique_id = entry_data[CONF_CONTROLLER_UNIQUE_ID]
self._device_name = device_name
self._device_manufacturer = device_manufacturer
@ -202,23 +205,3 @@ class Control4Entity(entity.Entity):
"model": self._device_model,
"via_device": (DOMAIN, self._controller_unique_id),
}
@property
def should_poll(self):
"""No need to poll. Coordinator notifies entity of updates."""
return False
@property
def available(self):
"""Return if entity is available."""
return self._coordinator.last_update_success
async def async_added_to_hass(self):
"""When entity is added to hass."""
self.async_on_remove(
self._coordinator.async_add_listener(self.async_write_ha_state)
)
async def async_update(self):
"""Update the state of the device."""
await self._coordinator.async_request_refresh()

8
homeassistant/components/control4/light.py
View file

@ -175,13 +175,13 @@ class Control4Light(Control4Entity, LightEntity):
@property
def is_on(self):
"""Return whether this light is on or off."""
return self._coordinator.data[self._idx]["value"] > 0
return self.coordinator.data[self._idx]["value"] > 0
@property
def brightness(self):
"""Return the brightness of this light between 0..255."""
if self._is_dimmer:
return round(self._coordinator.data[self._idx]["value"] * 2.55)
return round(self.coordinator.data[self._idx]["value"] * 2.55)
return None
@property
@ -213,7 +213,7 @@ class Control4Light(Control4Entity, LightEntity):
delay_time = (transition_length / 1000) + 0.7
_LOGGER.debug("Delaying light update by %s seconds", delay_time)
await asyncio.sleep(delay_time)
await self._coordinator.async_request_refresh()
await self.coordinator.async_request_refresh()
async def async_turn_off(self, **kwargs) -> None:
"""Turn the entity off."""
@ -232,4 +232,4 @@ class Control4Light(Control4Entity, LightEntity):
delay_time = (transition_length / 1000) + 0.7
_LOGGER.debug("Delaying light update by %s seconds", delay_time)
await asyncio.sleep(delay_time)
await self._coordinator.async_request_refresh()
await self.coordinator.async_request_refresh()