evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bump pytradfri to 8.0.1 and fix fan preset mode "Auto" bug (#63920)

Browse source 
* Move util functions

* Fix errors

* Revert changes

* Fix tests

* Use self.async_set_percentage()

* Fix calculation functions and associated tests

* Handle case of 0

* Update tests/components/tradfri/test_util.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update tests/components/tradfri/test_util.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update tests/components/tradfri/test_util.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Handle case of 0

* Update homeassistant/components/tradfri/fan.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
This commit is contained in:
Patrik Lindgren 2022-01-14 04:01:24 +01:00 • committed by GitHub
parent a978661545
commit b52a8ba37a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 62 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

37
tests/components/tradfri/test_util.py
View file

@ -1,22 +1,31 @@
"""Tradfri utility function tests."""
import pytest
from homeassistant.components.tradfri.fan import _from_fan_speed, _from_percentage
from homeassistant.components.tradfri.fan import _from_fan_percentage, _from_fan_speed
def test_from_fan_speed():
@pytest.mark.parametrize(
"fan_speed, expected_result",
[
(0, 0),
(2, 2),
(25, 49),
(50, 100),
],
)
def test_from_fan_speed(fan_speed, expected_result):
"""Test that we can convert fan speed to percentage value."""
assert _from_fan_speed(41) == 80
assert _from_fan_speed(fan_speed) == expected_result
def test_from_percentage():
@pytest.mark.parametrize(
"percentage, expected_result",
[
(1, 2),
(100, 50),
(50, 26),
],
)
def test_from_percentage(percentage, expected_result):
"""Test that we can convert percentage value to fan speed."""
assert _from_percentage(84) == 40
def test_from_percentage_limit():
"""
Test that we can convert percentage value to fan speed.
Handle special case of percent value being below 20.
"""
assert _from_percentage(10) == 0
assert _from_fan_percentage(percentage) == expected_result