From b2692ecc80b5cafa625064665c273295b1e7d5bc Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Fri, 9 Sep 2022 23:32:14 -0400 Subject: [PATCH] Fix ecowitt typing (#78171) --- homeassistant/components/ecowitt/binary_sensor.py | 2 +- homeassistant/components/ecowitt/diagnostics.py | 4 ++-- homeassistant/components/ecowitt/sensor.py | 5 ++++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/ecowitt/binary_sensor.py b/homeassistant/components/ecowitt/binary_sensor.py index e487009d74b..fbe2e017339 100644 --- a/homeassistant/components/ecowitt/binary_sensor.py +++ b/homeassistant/components/ecowitt/binary_sensor.py @@ -68,4 +68,4 @@ class EcowittBinarySensorEntity(EcowittEntity, BinarySensorEntity): @property def is_on(self) -> bool: """Return true if the binary sensor is on.""" - return self.ecowitt.value > 0 + return bool(self.ecowitt.value) diff --git a/homeassistant/components/ecowitt/diagnostics.py b/homeassistant/components/ecowitt/diagnostics.py index d02a5dadbcc..96fa020667b 100644 --- a/homeassistant/components/ecowitt/diagnostics.py +++ b/homeassistant/components/ecowitt/diagnostics.py @@ -25,13 +25,13 @@ async def async_get_device_diagnostics( "device": { "name": station.station, "model": station.model, - "frequency": station.frequency, + "frequency": station.frequence, "version": station.version, }, "raw": ecowitt.last_values[station_id], "sensors": { sensor.key: sensor.value - for sensor in station.sensors + for sensor in ecowitt.sensors.values() if sensor.station.key == station_id }, } diff --git a/homeassistant/components/ecowitt/sensor.py b/homeassistant/components/ecowitt/sensor.py index 843dc700dc0..bb580b6d4b7 100644 --- a/homeassistant/components/ecowitt/sensor.py +++ b/homeassistant/components/ecowitt/sensor.py @@ -1,5 +1,8 @@ """Support for Ecowitt Weather Stations.""" +from __future__ import annotations + import dataclasses +from datetime import datetime from typing import Final from aioecowitt import EcoWittListener, EcoWittSensor, EcoWittSensorTypes @@ -242,6 +245,6 @@ class EcowittSensorEntity(EcowittEntity, SensorEntity): self.entity_description = description @property - def native_value(self) -> StateType: + def native_value(self) -> StateType | datetime: """Return the state of the sensor.""" return self.ecowitt.value