From b0e87c09412288d5b648419f204bc652f63bb999 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 14 Feb 2024 13:51:44 -0600 Subject: [PATCH] Fix formatting of mac addresses from dhcp discovery mocking in nuki (#110585) dhcp returns addresses in lowercase without : --- tests/components/nuki/mock.py | 1 + tests/components/nuki/test_config_flow.py | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tests/components/nuki/mock.py b/tests/components/nuki/mock.py index e85d1de3933..56297240331 100644 --- a/tests/components/nuki/mock.py +++ b/tests/components/nuki/mock.py @@ -5,6 +5,7 @@ from tests.common import MockConfigEntry NAME = "Nuki_Bridge_75BCD15" HOST = "1.1.1.1" MAC = "01:23:45:67:89:ab" +DHCP_FORMATTED_MAC = "0123456789ab" HW_ID = 123456789 ID_HEX = "75BCD15" diff --git a/tests/components/nuki/test_config_flow.py b/tests/components/nuki/test_config_flow.py index 4079f21b1fe..b5f1b65af71 100644 --- a/tests/components/nuki/test_config_flow.py +++ b/tests/components/nuki/test_config_flow.py @@ -10,7 +10,7 @@ from homeassistant.components.nuki.const import DOMAIN from homeassistant.const import CONF_TOKEN from homeassistant.core import HomeAssistant -from .mock import HOST, MAC, MOCK_INFO, NAME, setup_nuki_integration +from .mock import DHCP_FORMATTED_MAC, HOST, MOCK_INFO, NAME, setup_nuki_integration async def test_form(hass: HomeAssistant) -> None: @@ -146,7 +146,9 @@ async def test_dhcp_flow(hass: HomeAssistant) -> None: """Test that DHCP discovery for new bridge works.""" result = await hass.config_entries.flow.async_init( DOMAIN, - data=dhcp.DhcpServiceInfo(hostname=NAME, ip=HOST, macaddress=MAC), + data=dhcp.DhcpServiceInfo( + hostname=NAME, ip=HOST, macaddress=DHCP_FORMATTED_MAC + ), context={"source": config_entries.SOURCE_DHCP}, ) @@ -186,7 +188,9 @@ async def test_dhcp_flow_already_configured(hass: HomeAssistant) -> None: await setup_nuki_integration(hass) result = await hass.config_entries.flow.async_init( DOMAIN, - data=dhcp.DhcpServiceInfo(hostname=NAME, ip=HOST, macaddress=MAC), + data=dhcp.DhcpServiceInfo( + hostname=NAME, ip=HOST, macaddress=DHCP_FORMATTED_MAC + ), context={"source": config_entries.SOURCE_DHCP}, )