evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use better names for zwave_js platforms that are self describing (#46083)

Browse source 
* use better names for platforms that are self describing

* add missing light change

* fix tests

* only use value_name in sensors and binary_sensors
This commit is contained in:
Raman Gupta 2021-02-06 05:08:25 -06:00 • committed by GitHub
parent ee98ea89dd
commit af4e6f856f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 50 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

20
homeassistant/components/zwave_js/sensor.py
View file

@ -64,6 +64,16 @@ async def async_setup_entry(
class ZwaveSensorBase(ZWaveBaseEntity):
"""Basic Representation of a Z-Wave sensor."""
def __init__(
self,
config_entry: ConfigEntry,
client: ZwaveClient,
info: ZwaveDiscoveryInfo,
) -> None:
"""Initialize a ZWaveSensorBase entity."""
super().__init__(config_entry, client, info)
self._name = self.generate_name(include_value_name=True)
@property
def device_class(self) -> Optional[str]:
"""Return the device class of the sensor."""
@ -132,7 +142,10 @@ class ZWaveNumericSensor(ZwaveSensorBase):
"""Initialize a ZWaveNumericSensor entity."""
super().__init__(config_entry, client, info)
if self.info.primary_value.command_class == CommandClass.BASIC:
self._name = self.generate_name(self.info.primary_value.command_class_name)
self._name = self.generate_name(
include_value_name=True,
alternate_value_name=self.info.primary_value.command_class_name,
)
@property
def state(self) -> float:
@ -166,8 +179,9 @@ class ZWaveListSensor(ZwaveSensorBase):
"""Initialize a ZWaveListSensor entity."""
super().__init__(config_entry, client, info)
self._name = self.generate_name(
self.info.primary_value.property_name,
[self.info.primary_value.property_key_name],
include_value_name=True,
alternate_value_name=self.info.primary_value.property_name,
additional_info=[self.info.primary_value.property_key_name],
)
@property