evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ensure recorder runs are cleaned up during purge (#36989)

Browse source 
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
This commit is contained in:
J. Nick Koston 2020-06-22 22:10:05 -05:00 • committed by GitHub
parent b4489e132c
commit ad6315be5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 45 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
homeassistant/components/recorder/purge.py
View file

@ -6,7 +6,7 @@ from sqlalchemy.exc import SQLAlchemyError
import homeassistant.util.dt as dt_util
from .models import Events, States
from .models import Events, RecorderRuns, States
from .util import session_scope
_LOGGER = logging.getLogger(__name__)
@ -33,6 +33,13 @@ def purge_old_data(instance, purge_days, repack):
)
_LOGGER.debug("Deleted %s events", deleted_rows)
deleted_rows = (
session.query(RecorderRuns)
.filter(RecorderRuns.start < purge_before)
.delete(synchronize_session=False)
)
_LOGGER.debug("Deleted %s recorder_runs", deleted_rows)
if repack:
# Execute sqlite or postgresql vacuum command to free up space on disk
if instance.engine.driver in ("pysqlite", "postgresql"):
@ -41,7 +48,7 @@ def purge_old_data(instance, purge_days, repack):
# Optimize mysql / mariadb tables to free up space on disk
elif instance.engine.driver == "mysqldb":
_LOGGER.debug("Optimizing SQL DB to free space")
instance.engine.execute("OPTIMIZE TABLE states, events")
instance.engine.execute("OPTIMIZE TABLE states, events, recorder_runs")
except SQLAlchemyError as err:
_LOGGER.warning("Error purging history: %s.", err)