evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change error state to be 'error' rather than 'unknown', trace error.

Browse source
This commit is contained in:
pavoni 2016-01-22 16:30:02 +00:00
parent 87a9fd8252
commit ad62591f43
2 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
homeassistant/components/sensor/template.py
View file

@ -12,7 +12,6 @@ import logging
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
from homeassistant.core import EVENT_STATE_CHANGED from homeassistant.core import EVENT_STATE_CHANGED
from homeassistant.const import ( from homeassistant.const import (
STATE_UNKNOWN,
ATTR_FRIENDLY_NAME, ATTR_FRIENDLY_NAME,
CONF_VALUE_TEMPLATE, CONF_VALUE_TEMPLATE,
ATTR_UNIT_OF_MEASUREMENT) ATTR_UNIT_OF_MEASUREMENT)
@ -24,6 +23,8 @@ _LOGGER = logging.getLogger(__name__)
CONF_SENSORS = 'sensors' CONF_SENSORS = 'sensors'
STATE_ERROR = 'error'
# pylint: disable=unused-argument # pylint: disable=unused-argument
def setup_platform(hass, config, add_devices, discovery_info=None): def setup_platform(hass, config, add_devices, discovery_info=None):
@ -107,5 +108,6 @@ class SensorTemplate(Entity):
def update(self): def update(self):
try: try:
self._state = template.render(self.hass, self._template) self._state = template.render(self.hass, self._template)
except TemplateError: except TemplateError as ex:
self._state = STATE_UNKNOWN self._state = STATE_ERROR
_LOGGER.error(ex)

2
tests/components/sensor/test_template.py
View file

@ -60,4 +60,4 @@ class TestTemplateSensor:
self.hass.states.set('sensor.test_state', 'Works') self.hass.states.set('sensor.test_state', 'Works')
self.hass.pool.block_till_done() self.hass.pool.block_till_done()
state = self.hass.states.get('sensor.test_template_sensor') state = self.hass.states.get('sensor.test_template_sensor')
assert state.state == 'unknown' assert state.state == 'error'