Allow split component definitions in packages (#16177)
* Allow split component definitions in packages Two different configuration styles are described in https://www.home-assistant.io/docs/configuration/devices/#style-2-list-each-device-separately But only one is allowed in packages according to https://www.home-assistant.io/docs/configuration/packages/ This change allows "Style 2" configuration in packages. * Added test for split component definition in packages
This commit is contained in:
parent
5ee4718e24
commit
ad47ece5c6
2 changed files with 23 additions and 2 deletions
|
@ -171,7 +171,7 @@ def _no_duplicate_auth_mfa_module(configs: Sequence[Dict[str, Any]]) \
|
||||||
|
|
||||||
PACKAGES_CONFIG_SCHEMA = vol.Schema({
|
PACKAGES_CONFIG_SCHEMA = vol.Schema({
|
||||||
cv.slug: vol.Schema( # Package names are slugs
|
cv.slug: vol.Schema( # Package names are slugs
|
||||||
{cv.slug: vol.Any(dict, list, None)}) # Only slugs for component names
|
{cv.string: vol.Any(dict, list, None)}) # Component configuration
|
||||||
})
|
})
|
||||||
|
|
||||||
CUSTOMIZE_DICT_SCHEMA = vol.Schema({
|
CUSTOMIZE_DICT_SCHEMA = vol.Schema({
|
||||||
|
@ -662,7 +662,10 @@ def merge_packages_config(hass: HomeAssistant, config: Dict, packages: Dict,
|
||||||
for comp_name, comp_conf in pack_conf.items():
|
for comp_name, comp_conf in pack_conf.items():
|
||||||
if comp_name == CONF_CORE:
|
if comp_name == CONF_CORE:
|
||||||
continue
|
continue
|
||||||
component = get_component(hass, comp_name)
|
# If component name is given with a trailing description, remove it
|
||||||
|
# when looking for component
|
||||||
|
domain = comp_name.split(' ')[0]
|
||||||
|
component = get_component(hass, domain)
|
||||||
|
|
||||||
if component is None:
|
if component is None:
|
||||||
_log_pkg_error(pack_name, comp_name, config, "does not exist")
|
_log_pkg_error(pack_name, comp_name, config, "does not exist")
|
||||||
|
|
|
@ -965,3 +965,21 @@ async def test_disallowed_duplicated_auth_mfa_module_config(hass):
|
||||||
}
|
}
|
||||||
with pytest.raises(Invalid):
|
with pytest.raises(Invalid):
|
||||||
await config_util.async_process_ha_core_config(hass, core_config)
|
await config_util.async_process_ha_core_config(hass, core_config)
|
||||||
|
|
||||||
|
|
||||||
|
def test_merge_split_component_definition(hass):
|
||||||
|
"""Test components with trailing description in packages are merged."""
|
||||||
|
packages = {
|
||||||
|
'pack_1': {'light one': {'l1': None}},
|
||||||
|
'pack_2': {'light two': {'l2': None},
|
||||||
|
'light three': {'l3': None}},
|
||||||
|
}
|
||||||
|
config = {
|
||||||
|
config_util.CONF_CORE: {config_util.CONF_PACKAGES: packages},
|
||||||
|
}
|
||||||
|
config_util.merge_packages_config(hass, config, packages)
|
||||||
|
|
||||||
|
assert len(config) == 4
|
||||||
|
assert len(config['light one']) == 1
|
||||||
|
assert len(config['light two']) == 1
|
||||||
|
assert len(config['light three']) == 1
|
||||||
|
|
Loading…
Add table
Reference in a new issue