evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Netatmo device trigger (#80047)

Browse source
This commit is contained in:
Tobias Sauerwein 2022-10-10 22:04:41 +02:00 • committed by GitHub
parent e8af007124
commit aa58d7fbd6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
homeassistant/components/netatmo/device_trigger.py
View file

@ -38,10 +38,10 @@ from .const import (
CONF_SUBTYPE = "subtype"
DEVICES = {
"NACamera": INDOOR_CAMERA_TRIGGERS,
"NOC": OUTDOOR_CAMERA_TRIGGERS,
"NATherm1": CLIMATE_TRIGGERS,
"NRV": CLIMATE_TRIGGERS,
"Smart Indoor Camera": INDOOR_CAMERA_TRIGGERS,
"Smart Outdoor Camera": OUTDOOR_CAMERA_TRIGGERS,
"Smart Thermostat": CLIMATE_TRIGGERS,
"Smart Valve": CLIMATE_TRIGGERS,
}
SUBTYPES = {

22
tests/components/netatmo/test_device_trigger.py
View file

@ -47,10 +47,10 @@ def calls(hass):
@pytest.mark.parametrize(
"platform,device_type,event_types",
[
("camera", "NOC", OUTDOOR_CAMERA_TRIGGERS),
("camera", "NACamera", INDOOR_CAMERA_TRIGGERS),
("climate", "NRV", CLIMATE_TRIGGERS),
("climate", "NATherm1", CLIMATE_TRIGGERS),
("camera", "Smart Outdoor Camera", OUTDOOR_CAMERA_TRIGGERS),
("camera", "Smart Indoor Camera", INDOOR_CAMERA_TRIGGERS),
("climate", "Smart Valve", CLIMATE_TRIGGERS),
("climate", "Smart Thermostat", CLIMATE_TRIGGERS),
],
)
async def test_get_triggers(
@ -105,15 +105,15 @@ async def test_get_triggers(
@pytest.mark.parametrize(
"platform,camera_type,event_type",
[("camera", "NOC", trigger) for trigger in OUTDOOR_CAMERA_TRIGGERS]
+ [("camera", "NACamera", trigger) for trigger in INDOOR_CAMERA_TRIGGERS]
[("camera", "Smart Outdoor Camera", trigger) for trigger in OUTDOOR_CAMERA_TRIGGERS]
+ [("camera", "Smart Indoor Camera", trigger) for trigger in INDOOR_CAMERA_TRIGGERS]
+ [
("climate", "NRV", trigger)
("climate", "Smart Valve", trigger)
for trigger in CLIMATE_TRIGGERS
if trigger not in SUBTYPES
]
+ [
("climate", "NATherm1", trigger)
("climate", "Smart Thermostat", trigger)
for trigger in CLIMATE_TRIGGERS
if trigger not in SUBTYPES
],
@ -183,12 +183,12 @@ async def test_if_fires_on_event(
@pytest.mark.parametrize(
"platform,camera_type,event_type,sub_type",
[
("climate", "NRV", trigger, subtype)
("climate", "Smart Valve", trigger, subtype)
for trigger in SUBTYPES
for subtype in SUBTYPES[trigger]
]
+ [
("climate", "NATherm1", trigger, subtype)
("climate", "Smart Thermostat", trigger, subtype)
for trigger in SUBTYPES
for subtype in SUBTYPES[trigger]
],
@ -262,7 +262,7 @@ async def test_if_fires_on_event_with_subtype(
@pytest.mark.parametrize(
"platform,device_type,event_type",
[("climate", "NAPLUG", trigger) for trigger in CLIMATE_TRIGGERS],
[("climate", "NAPlug", trigger) for trigger in CLIMATE_TRIGGERS],
)
async def test_if_invalid_device(
hass, device_reg, entity_reg, platform, device_type, event_type