Use pyspcwebgw for SPC component (#16214)

* Use pyspcwebgw library.

* Support alarm triggering.

* Update requirements.

* Add pyspcwebgw to test reqs.

* Also update script.

* Use dispatcher.

* Address review feedback.

homeassistant/components/binary_sensor/spc.py

@@ -4,87 +4,66 @@ Support for Vanderbilt (formerly Siemens) SPC alarm systems.
 For more details about this platform, please refer to the documentation at
 https://home-assistant.io/components/binary_sensor.spc/
 """
-import asyncio
 import logging
 
 from homeassistant.components.binary_sensor import BinarySensorDevice
-from homeassistant.components.spc import ATTR_DISCOVER_DEVICES, DATA_REGISTRY
-from homeassistant.const import STATE_OFF, STATE_ON, STATE_UNAVAILABLE
+from homeassistant.helpers.dispatcher import async_dispatcher_connect
+from homeassistant.core import callback
+from homeassistant.components.spc import (
+    ATTR_DISCOVER_DEVICES, SIGNAL_UPDATE_SENSOR)
 
 _LOGGER = logging.getLogger(__name__)
 
-SPC_TYPE_TO_DEVICE_CLASS = {
-    '0': 'motion',
-    '1': 'opening',
-    '3': 'smoke',
-}
 
-SPC_INPUT_TO_SENSOR_STATE = {
-    '0': STATE_OFF,
-    '1': STATE_ON,
-}
+def _get_device_class(zone_type):
+    from pyspcwebgw.const import ZoneType
+    return {
+        ZoneType.ALARM: 'motion',
+        ZoneType.ENTRY_EXIT: 'opening',
+        ZoneType.FIRE: 'smoke',
+    }.get(zone_type)
 
 
-def _get_device_class(spc_type):
-    """Get the device class."""
-    return SPC_TYPE_TO_DEVICE_CLASS.get(spc_type, None)
-
-
-def _get_sensor_state(spc_input):
-    """Get the sensor state."""
-    return SPC_INPUT_TO_SENSOR_STATE.get(spc_input, STATE_UNAVAILABLE)
-
-
-def _create_sensor(hass, zone):
-    """Create a SPC sensor."""
-    return SpcBinarySensor(
-        zone_id=zone['id'], name=zone['zone_name'],
-        state=_get_sensor_state(zone['input']),
-        device_class=_get_device_class(zone['type']),
-        spc_registry=hass.data[DATA_REGISTRY])
-
-
-@asyncio.coroutine
-def async_setup_platform(hass, config, async_add_entities,
-                         discovery_info=None):
+async def async_setup_platform(hass, config, async_add_entities,
+                               discovery_info=None):
     """Set up the SPC binary sensor."""
     if (discovery_info is None or
             discovery_info[ATTR_DISCOVER_DEVICES] is None):
         return
 
-    async_add_entities(
-        _create_sensor(hass, zone)
-        for zone in discovery_info[ATTR_DISCOVER_DEVICES]
-        if _get_device_class(zone['type']))
+    async_add_entities(SpcBinarySensor(zone)
+                       for zone in discovery_info[ATTR_DISCOVER_DEVICES]
+                       if _get_device_class(zone.type))
 
 
 class SpcBinarySensor(BinarySensorDevice):
     """Representation of a sensor based on a SPC zone."""
 
-    def __init__(self, zone_id, name, state, device_class, spc_registry):
+    def __init__(self, zone):
         """Initialize the sensor device."""
-        self._zone_id = zone_id
-        self._name = name
-        self._state = state
-        self._device_class = device_class
+        self._zone = zone
 
-        spc_registry.register_sensor_device(zone_id, self)
+    async def async_added_to_hass(self):
+        """Call for adding new entities."""
+        async_dispatcher_connect(self.hass,
+                                 SIGNAL_UPDATE_SENSOR.format(self._zone.id),
+                                 self._update_callback)
 
-    @asyncio.coroutine
-    def async_update_from_spc(self, state, extra):
-        """Update the state of the device."""
-        self._state = state
-        yield from self.async_update_ha_state()
+    @callback
+    def _update_callback(self):
+        """Call update method."""
+        self.async_schedule_update_ha_state(True)
 
     @property
     def name(self):
         """Return the name of the device."""
-        return self._name
+        return self._zone.name
 
     @property
     def is_on(self):
         """Whether the device is switched on."""
-        return self._state == STATE_ON
+        from pyspcwebgw.const import ZoneInput
+        return self._zone.input == ZoneInput.OPEN
 
     @property
     def hidden(self) -> bool:
@@ -100,4 +79,4 @@ class SpcBinarySensor(BinarySensorDevice):
     @property
     def device_class(self):
         """Return the device class."""
-        return self._device_class
+        return _get_device_class(self._zone.type)