From a584d7b5c9849ca97fdcd855c933258cd1391a09 Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Thu, 14 Oct 2021 22:31:12 +0200 Subject: [PATCH] Add service configuration URL to Stookalert (#57697) --- .../components/stookalert/binary_sensor.py | 33 +++++++------------ homeassistant/components/stookalert/const.py | 1 - 2 files changed, 11 insertions(+), 23 deletions(-) diff --git a/homeassistant/components/stookalert/binary_sensor.py b/homeassistant/components/stookalert/binary_sensor.py index 07e89f3c97e..b75790cef8a 100644 --- a/homeassistant/components/stookalert/binary_sensor.py +++ b/homeassistant/components/stookalert/binary_sensor.py @@ -12,26 +12,14 @@ from homeassistant.components.binary_sensor import ( BinarySensorEntity, ) from homeassistant.config_entries import SOURCE_IMPORT, ConfigEntry -from homeassistant.const import ( - ATTR_IDENTIFIERS, - ATTR_MANUFACTURER, - ATTR_MODEL, - ATTR_NAME, - CONF_NAME, -) +from homeassistant.const import CONF_NAME from homeassistant.core import HomeAssistant from homeassistant.helpers import config_validation as cv +from homeassistant.helpers.entity import DeviceInfo from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.typing import ConfigType, DiscoveryInfoType -from .const import ( - ATTR_ENTRY_TYPE, - CONF_PROVINCE, - DOMAIN, - ENTRY_TYPE_SERVICE, - LOGGER, - PROVINCES, -) +from .const import CONF_PROVINCE, DOMAIN, ENTRY_TYPE_SERVICE, LOGGER, PROVINCES DEFAULT_NAME = "Stookalert" ATTRIBUTION = "Data provided by rivm.nl" @@ -90,13 +78,14 @@ class StookalertBinarySensor(BinarySensorEntity): self._client = client self._attr_name = f"Stookalert {entry.data[CONF_PROVINCE]}" self._attr_unique_id = entry.unique_id - self._attr_device_info = { - ATTR_IDENTIFIERS: {(DOMAIN, f"{entry.entry_id}")}, - ATTR_NAME: entry.data[CONF_PROVINCE], - ATTR_MANUFACTURER: "RIVM", - ATTR_MODEL: "Stookalert", - ATTR_ENTRY_TYPE: ENTRY_TYPE_SERVICE, - } + self._attr_device_info = DeviceInfo( + identifiers={(DOMAIN, f"{entry.entry_id}")}, + name=entry.data[CONF_PROVINCE], + manufacturer="RIVM", + model="Stookalert", + entry_type=ENTRY_TYPE_SERVICE, + configuration_url="https://www.rivm.nl/stookalert", + ) def update(self) -> None: """Update the data from the Stookalert handler.""" diff --git a/homeassistant/components/stookalert/const.py b/homeassistant/components/stookalert/const.py index bbd5922b82a..72e39e60048 100644 --- a/homeassistant/components/stookalert/const.py +++ b/homeassistant/components/stookalert/const.py @@ -22,5 +22,4 @@ PROVINCES: Final = ( "Zuid-Holland", ) -ATTR_ENTRY_TYPE: Final = "entry_type" ENTRY_TYPE_SERVICE: Final = "service"