evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor persistent notification to no longer route all data via a service (#57157)

Browse source 
* Convert persistent notification tests to async

* Create/dismiss persistent notifications in exposed functions, not service calls

* Fix notify persistent_notification

* Remove setting up persistent_notification

* Drop more setups

* Empty methods

* Undeprecate sync methods because too big task

* Fix setup clearing notifications

* Fix a bunch of tests

* Fix more tests

* Uno mas

* Test persistent notification events

* Clean up stale comment

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
This commit is contained in:
Paulus Schoutsen 2021-10-07 03:58:00 -07:00 • committed by GitHub
parent 750dd9186e
commit a4d9019ffc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
198 changed files with 848 additions and 1114 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/components/rfxtrx/test_device_action.py
View file

@ -15,7 +15,6 @@ from tests.common import (
MockConfigEntry,
assert_lists_same,
async_get_device_automations,
async_mock_service,
mock_device_registry,
mock_registry,
)
@ -169,7 +168,6 @@ async def test_action(
async def test_invalid_action(hass, device_reg: DeviceRegistry):
"""Test for invalid actions."""
device = DEVICE_LIGHTING_1
notification_calls = async_mock_service(hass, "persistent_notification", "create")
await setup_entry(hass, {device.code: {"signal_repetitions": 1}})
@ -199,8 +197,8 @@ async def test_invalid_action(hass, device_reg: DeviceRegistry):
)
await hass.async_block_till_done()
assert len(notification_calls) == 1
assert len(notifications := hass.states.async_all("persistent_notification")) == 1
assert (
"The following integrations and platforms could not be set up"
in notification_calls[0].data["message"]
in notifications[0].attributes["message"]
)