From a13535b0c7ee3fdee584d86f028ac68357bfd31c Mon Sep 17 00:00:00 2001 From: epenet <6771947+epenet@users.noreply.github.com> Date: Thu, 9 Feb 2023 16:55:02 +0100 Subject: [PATCH] Bump renault-api to 0.1.12 (#87773) fix https://github.com/hacf-fr/renault-api/pull/789 --- homeassistant/components/renault/__init__.py | 3 ++- homeassistant/components/renault/manifest.json | 2 +- requirements_all.txt | 2 +- requirements_test_all.txt | 2 +- tests/components/renault/test_init.py | 6 ++++-- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/homeassistant/components/renault/__init__.py b/homeassistant/components/renault/__init__.py index 21ce5118401..b02938b1652 100644 --- a/homeassistant/components/renault/__init__.py +++ b/homeassistant/components/renault/__init__.py @@ -1,5 +1,6 @@ """Support for Renault devices.""" import aiohttp +from renault_api.gigya.exceptions import GigyaException from homeassistant.config_entries import ConfigEntry from homeassistant.const import CONF_PASSWORD, CONF_USERNAME @@ -18,7 +19,7 @@ async def async_setup_entry(hass: HomeAssistant, config_entry: ConfigEntry) -> b login_success = await renault_hub.attempt_login( config_entry.data[CONF_USERNAME], config_entry.data[CONF_PASSWORD] ) - except aiohttp.ClientConnectionError as exc: + except (aiohttp.ClientConnectionError, GigyaException) as exc: raise ConfigEntryNotReady() from exc if not login_success: diff --git a/homeassistant/components/renault/manifest.json b/homeassistant/components/renault/manifest.json index efdeb8ae480..9fade49b4b4 100644 --- a/homeassistant/components/renault/manifest.json +++ b/homeassistant/components/renault/manifest.json @@ -8,5 +8,5 @@ "iot_class": "cloud_polling", "loggers": ["renault_api"], "quality_scale": "platinum", - "requirements": ["renault-api==0.1.11"] + "requirements": ["renault-api==0.1.12"] } diff --git a/requirements_all.txt b/requirements_all.txt index cccf546abc3..46757f067dc 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -2228,7 +2228,7 @@ raspyrfm-client==1.2.8 regenmaschine==2022.11.0 # homeassistant.components.renault -renault-api==0.1.11 +renault-api==0.1.12 # homeassistant.components.reolink reolink-aio==0.4.0 diff --git a/requirements_test_all.txt b/requirements_test_all.txt index 70f99a48281..d23f59872fa 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -1573,7 +1573,7 @@ radiotherm==2.1.0 regenmaschine==2022.11.0 # homeassistant.components.renault -renault-api==0.1.11 +renault-api==0.1.12 # homeassistant.components.reolink reolink-aio==0.4.0 diff --git a/tests/components/renault/test_init.py b/tests/components/renault/test_init.py index 8b4ed379db5..7f2aee9d7bd 100644 --- a/tests/components/renault/test_init.py +++ b/tests/components/renault/test_init.py @@ -1,10 +1,11 @@ """Tests for Renault setup process.""" from collections.abc import Generator +from typing import Any from unittest.mock import patch import aiohttp import pytest -from renault_api.gigya.exceptions import InvalidCredentialsException +from renault_api.gigya.exceptions import GigyaException, InvalidCredentialsException from homeassistant.components.renault.const import DOMAIN from homeassistant.config_entries import ConfigEntry, ConfigEntryState @@ -58,8 +59,9 @@ async def test_setup_entry_bad_password( assert not hass.data.get(DOMAIN) +@pytest.mark.parametrize("side_effect", [aiohttp.ClientConnectionError, GigyaException]) async def test_setup_entry_exception( - hass: HomeAssistant, config_entry: ConfigEntry + hass: HomeAssistant, config_entry: ConfigEntry, side_effect: Any ) -> None: """Test ConfigEntryNotReady when API raises an exception during entry setup.""" # In this case we are testing the condition where async_setup_entry raises