evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address late review for Renault integration (#55230)

Browse source 
* Add type hints

* Fix isort

* tweaks to state attributes

* Move lambdas to regular functions

* Split CHECK_ATTRIBUTES into DYNAMIC_ATTRIBUTES and FIXED_ATTRIBUTES

* Clarify tests

* Fix typo
This commit is contained in:
epenet 2021-08-27 07:22:23 +02:00 • committed by GitHub
parent 176fd39e0b
commit 9ba504cd78
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 112 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/components/renault/test_init.py
View file

@ -6,11 +6,12 @@ from renault_api.gigya.exceptions import InvalidCredentialsException
from homeassistant.components.renault.const import DOMAIN
from homeassistant.config_entries import ConfigEntryState
from homeassistant.core import HomeAssistant
from . import get_mock_config_entry, setup_renault_integration_simple
async def test_setup_unload_entry(hass):
async def test_setup_unload_entry(hass: HomeAssistant):
"""Test entry setup and unload."""
with patch("homeassistant.components.renault.PLATFORMS", []):
config_entry = await setup_renault_integration_simple(hass)
@ -26,7 +27,7 @@ async def test_setup_unload_entry(hass):
assert config_entry.entry_id not in hass.data[DOMAIN]
async def test_setup_entry_bad_password(hass):
async def test_setup_entry_bad_password(hass: HomeAssistant):
"""Test entry setup and unload."""
# Create a mock entry so we don't have to go through config flow
config_entry = get_mock_config_entry()
@ -44,7 +45,7 @@ async def test_setup_entry_bad_password(hass):
assert not hass.data.get(DOMAIN)
async def test_setup_entry_exception(hass):
async def test_setup_entry_exception(hass: HomeAssistant):
"""Test ConfigEntryNotReady when API raises an exception during entry setup."""
config_entry = get_mock_config_entry()
config_entry.add_to_hass(hass)